Yaniv Bronhaim has posted comments on this change.
Change subject: frontend: node upgrade message improvement
......................................................................
Patch Set 9:
(3 comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
Line 670: protected static boolean shouldAlertUpgrade(ArrayList<RpmVersion>
isos, String[] hostOs)
Line 671: {
Line 672: // hostOs is the result of the dash delimited string that is
provided by VdsDynamic.hostOs
Line 673: // That field is retrieved from getVdsCaps
("operatingSystem") field in the format of
Line 674: // Prefix-whitespace-Version-whitespace-Release which is
similar to Rpm formath
s\formath\format.
for me, you could just say the last sentence :
* hostOs[0] -> prefix
* hostOs[1] -> version
* hostOs[2] -> revision\release
but this also great. thanks
Line 675: // This means hostOs[0] holds "prefix", hostOs[1] holds
"version" and hostOs[2] holds revision
Line 676: boolean alert = false;
Line 677: Version hostVersion = new Version(hostOs[1].trim());
Line 678: //String version_host[] = hostOs[1].split("\\.");
//$NON-NLS-1$ //$NON-NLS-2$
Line 674: // Prefix-whitespace-Version-whitespace-Release which is
similar to Rpm formath
Line 675: // This means hostOs[0] holds "prefix", hostOs[1] holds
"version" and hostOs[2] holds revision
Line 676: boolean alert = false;
Line 677: Version hostVersion = new Version(hostOs[1].trim());
Line 678: //String version_host[] = hostOs[1].split("\\.");
//$NON-NLS-1$ //$NON-NLS-2$
the comment can be removed i guess..
Line 679: String release_host = hostOs[2].trim();
Line 680:
Line 681: for (RpmVersion iso : isos) {
Line 682: // Major check
Line 675: // This means hostOs[0] holds "prefix", hostOs[1] holds
"version" and hostOs[2] holds revision
Line 676: boolean alert = false;
Line 677: Version hostVersion = new Version(hostOs[1].trim());
Line 678: //String version_host[] = hostOs[1].split("\\.");
//$NON-NLS-1$ //$NON-NLS-2$
Line 679: String release_host = hostOs[2].trim();
keep constancy, rename release_host to hostRelease. and try call it always
release and not rivision (as you wrote in the comment above)
Line 680:
Line 681: for (RpmVersion iso : isos) {
Line 682: // Major check
Line 683: if (hostVersion.getMajor() == iso.getMajor()) {
--
To view, visit http://gerrit.ovirt.org/17987
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76bd2948524110ec80923e855bd1f49e09e17046
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
