Tomas Jelinek has posted comments on this change.
Change subject: core, engine, webadmin: Initial support for alternative
architectures
......................................................................
Patch Set 8:
(2 comments)
The template has the architecture configuration but you do not use that when
making VMs or pools from templates. So what is the point of this config on
template?
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java
Line 414: obj.setVdsGroupName(instance.getVdsGroupName());
Line 415: obj.setVmType(instance.getVmType());
Line 416: obj.setId(instance.getId());
Line 417: obj.setDiskList(instance.getDiskList());
Line 418: obj.setRunAndPause(instance.isRunAndPause());
Are you sure you don't not need to clone the ArchitectureType also here?
Line 419:
Line 420: return obj;
Line 421: }
Line 422:
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
Line 585: name);
Line 586: }
Line 587: }
Line 588:
Line 589: public void postNameUniqueCheck(UserPortalListModel
userPortalListModel)
I would say you need to set the architecture up also here
Line 590: {
Line 591: UnitVmModel model = (UnitVmModel)
userPortalListModel.getWindow();
Line 592: UserPortalItemModel selectedItem = (UserPortalItemModel)
userPortalListModel.getSelectedItem();
Line 593: VM vm = (VM) selectedItem.getEntity();
--
To view, visit http://gerrit.ovirt.org/16700
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I33ed9231a6467aa59e8f3223ba9d61b6e68039fa
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
