Allon Mureinik has posted comments on this change.
Change subject: core: rename methods to start with lowercase
......................................................................
Patch Set 2:
(4 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
Line 255
Line 256
Line 257
Line 258
Line 259
Great change, but unrelated to this patch - please separate.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 281: return true;
Line 282: }
Line 283:
Line 284: public static boolean checkCpuSockets(int num_of_sockets, int
cpu_per_socket, String compatibility_version,
Line 285: List<String>
CanDoActionMessages) {
is this spacing intentional?
Line 286: boolean retValue = true;
Line 287: if (retValue
Line 288: && (num_of_sockets * cpu_per_socket) >
Config.<Integer> GetValue(ConfigValues.MaxNumOfVmCpus,
Line 289: compatibility_version)) {
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java
Line 245
Line 246
Line 247
Line 248
Line 249
consider doing this in a separate patch
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java
Line 76
Line 77
Line 78
Line 79
Line 80
Great change, but unrelated to this patch.
--
To view, visit http://gerrit.ovirt.org/18546
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d77789be17e90f63c734dba3365c0178326029
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
