Alissa Bonas has posted comments on this change. Change subject: core: rename methods to start with lowercase ......................................................................
Patch Set 2: (3 comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java Line 255 Line 256 Line 257 Line 258 Line 259 see my comment in AddDiskToVmCommandTest.java related to this dao .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java Line 245 Line 246 Line 247 Line 248 Line 249 this method is not used. it causes a findbug warning because it starts with uppercase. instead of renaming it and then removing it in separate patch - why waste time? I don't see any reason to separate it. .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java Line 76 Line 77 Line 78 Line 79 Line 80 It is definitely related to the patch. Patch cleans findbugs warnings. This particular change cleans a findbug warning about ambiguous 2 methods - getStorageDomainStaticDAO and getStorageDomainStaticDao. Since one of them is not used, I removed the leftovers from tests too - and it will both remove unused method and solve the ambiguous 2 methods findbug. -- To view, visit http://gerrit.ovirt.org/18546 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3d77789be17e90f63c734dba3365c0178326029 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
