Kanagaraj M has posted comments on this change.
Change subject: engine: Support for gluster task monitoring
......................................................................
Patch Set 6:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java
Line 134: }
Line 135:
Line 136: private static boolean hasTaskCompleted(GlusterAsyncTask task) {
Line 137: if (JobExecutionStatus.ABORTED.equals(task.getStatus()) ||
JobExecutionStatus.FINISHED.equals(task.getStatus())
Line 138: ||
JobExecutionStatus.FAILED.equals(task.getStatus())) {
Why "equals" instead of "==".
Above method also has same logic, please remove the duplication.
Line 139: return true;
Line 140: }
Line 141: return false;
Line 142: }
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1307: GlusterHostUUIDSupport(427),
Line 1308:
Line 1309: @TypeConverterAttribute(Boolean.class)
Line 1310: @DefaultValueAttribute("true")
Line 1311: GlusterAysncTasksSupport(427),
It should be 428
Line 1312:
Line 1313: @TypeConverterAttribute(String.class)
Line 1314: @DefaultValueAttribute("AttestationService/resources/PollHosts")
Line 1315: PollUri(427),
--
To view, visit http://gerrit.ovirt.org/17965
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica67b56804cbb892886160f0b22043687277d476
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
