Sahina Bose has posted comments on this change.
Change subject: engine: Support for gluster task monitoring
......................................................................
Patch Set 6:
(5 comments)
Patchset to follow
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java
Line 134: }
Line 135:
Line 136: private static boolean hasTaskCompleted(GlusterAsyncTask task) {
Line 137: if (JobExecutionStatus.ABORTED.equals(task.getStatus()) ||
JobExecutionStatus.FINISHED.equals(task.getStatus())
Line 138: ||
JobExecutionStatus.FAILED.equals(task.getStatus())) {
Will change equals.
But the methods are not same, one checks for success and the other for
completion.
A task can be completed with failed state as well.
Line 139: return true;
Line 140: }
Line 141: return false;
Line 142: }
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1307: GlusterHostUUIDSupport(427),
Line 1308:
Line 1309: @TypeConverterAttribute(Boolean.class)
Line 1310: @DefaultValueAttribute("true")
Line 1311: GlusterAysncTasksSupport(427),
Done
Line 1312:
Line 1313: @TypeConverterAttribute(String.class)
Line 1314: @DefaultValueAttribute("AttestationService/resources/PollHosts")
Line 1315: PollUri(427),
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/gluster/GlusterFeatureSupported.java
Line 60: /**
Line 61: * @param version
Line 62: * Compatibility version to check for.
Line 63: * @return <code>true</code> if gluster host UUID is supported,
<code>false</code> if it's not.
Line 64: */
Done
Line 65: public static boolean glusterAsyncTasks(Version version) {
Line 66: return
supportedInConfig(ConfigValues.GlusterAysncTasksSupport, version);
Line 67: }
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoDbFacadeImpl.java
Line 180: @Override
Line 181: public GlusterVolumeEntity getVolumeByGlusterTask(Guid taskId) {
Line 182: GlusterVolumeEntity volume = getCallsHandler().executeRead(
Line 183: "GetGlusterVolumeByGlusterTaskId", volumeRowMapper,
Line 184: getCustomMapSqlParameterSource().addValue("task_id",
taskId));
I do not need the task details and related entities of volume, only the volume
entity is required
Line 185: return volume;
Line 186: }
Line 187:
Line 188: @Override
....................................................
File packaging/dbscripts/gluster_volumes_sp.sql
Line 152: END; $procedure$
Line 153: LANGUAGE plpgsql;
Line 154:
Line 155: Create or replace FUNCTION GetGlusterVolumeByGlusterTaskId(v_task_id
UUID)
Line 156: RETURNS SETOF gluster_volumes_view
Done
Line 157: AS $procedure$
Line 158: BEGIN
Line 159: RETURN QUERY SELECT *
Line 160: FROM gluster_volumes_view
--
To view, visit http://gerrit.ovirt.org/17965
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica67b56804cbb892886160f0b22043687277d476
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
