Ori Liel has posted comments on this change.
Change subject: restapi: Modified gluster volume rebalance action
......................................................................
Patch Set 5:
1) I don't understand the motivation for the rename rebalance-->startrebalance.
I think rebalance is a better name. Is it for consistency with GUI? From API
point of view this is not an acceptable argument; we want the clearest,
friendliest API, regardless of how things are in the GUI.
2) If any customer is currently using the API, their scripts will break
('rebalance' will no longer work.
3) Could you please elaborate about task-id? IIUC it's meant for
task-monitoring, and we recently had infrastructure added for task-monitoring
of 3rd parties by Eli Mesika, and that infrastructure should be used, if
there's no good reason not to.
--
To view, visit http://gerrit.ovirt.org/18208
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9fd560cc1b6a0db9cc28647bc311cb9f1b9e3b3
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
