i've noticed that the Makefile in src/themes utilizes the $USER variable for 
chowning the themes files ...
Makefile.am:    if [ -n "$(USER)" ]; then chown -R $(USER) 
$(DESTDIR)$(ethemedir); else chown -R root $(DESTDIR)$(ethemedir); fi

any particular reason ?  the trouble i see is that if the user is building the 
e16 pkg as a non-root user (for obvious reasons) and then goes to install it 
into a temporary directory before su-ing to root and doing the final install 
to /, the permissions may be a little messed ...
imho it should just be a chown -R root $(DESTDIR)$(ethemedir) w/out any checks 
against the $USER variable ... after all, why are the themes special ?  none 
of the other subsections of e16 do this ...

-mike

Attachment: pgp00000.pgp
Description: signature

Reply via email to