On Mon, 7 Mar 2005 15:57:48 -0600 Ibukun Olumuyiwa <[EMAIL PROTECTED]>
(Bbabbled:
(B
(B> Michel,
(B>
(B> Thanks for the patch. It looks good, except for the configure.in fix. The
(B> manual checks for headers were done for a reason - I did not want to link
(B> entrance with other ecore libraries unless it actually required them
(B> (namely ecore_job, ecore_fb and ecore_config at this point). The current
(B> method works as it is -- I'd rather keep it that way. I'll see about
(B> putting this in tonight.
(B
(Bnot sure what the headers have to do with this? shared lib dependencies should
(Bhandle the rest - just link with ecore and ecore_job if you use ecore_jobs
(Byourself, or ecore_evas if you use that, or ecore_x etc. those libraries should
(Bbring in their own dependencies automatically. the headers wont be needed :)
(B
(B> Ibukun
(B>
(B> On Mon 07 Mar 2005, Corey Donohoe wrote:
(B> > thanks, i'll try to tend to this if xcomp doesn't beat me to it.
(B> >
(B> > * Michel Briand ([EMAIL PROTECTED]) wrote:
(B> > > -----BEGIN PGP SIGNED MESSAGE-----
(B> > > Hash: SHA1
(B> > >
(B> > > Hello Ibukun
(B> > >
(B> > > please chech these files:
(B> > >
(B> > > configure.in: correct EFL check against *-config files
(B> > > main.c: correct evas check for GL renderer
(B> > > entrance_session.c: fix a segfault when DISPLAY=(null)
(B> > >
(B> > > With kind regards,
(B> > >
(B> > > Michel
(B> > > -----BEGIN PGP SIGNATURE-----
(B> > > Version: GnuPG v1.4.0 (GNU/Linux)
(B> > >
(B> > > iD8DBQFCKENWMSWL0LSvaHgRAiDiAJ9v0wdUOvJXsSFQgd6f7kqk3L/gMwCgr6nS
(B> > > 8ymbLCMQTON1VzU0aDrv1O0=
(B> > > =y+GK
(B> > > -----END PGP SIGNATURE-----
(B> >
(B> > > ? configure.in.pc
(B> > > ? patch
(B> > > Index: configure.in
(B> > > ===================================================================
(B> > > RCS file: /cvsroot/enlightenment/e17/apps/entrance/configure.in,v
(B> > > retrieving revision 1.39
(B> > > diff -r1.39 configure.in
(B> > > 44,67c44,51
(B> > > < AC_ARG_WITH(edb,
(B> > > < [ --with-edb=DIR use edb in <DIR>],
(B> > > < [ CFLAGS="$CFLAGS -I$withval/include"
(B> > > < LIBS="-L$withval/lib $LIBS"])
(B> > > < AC_ARG_WITH(evas,
(B> > > < [ --with-evas=DIR use evas in <DIR>],
(B> > > < [ CFLAGS="$CFLAGS -I$withval/include"
(B> > > < LIBS="-L$withval/lib $LIBS"])
(B> > > < AC_ARG_WITH(ecore,
(B> > > < [ --with-ecore=DIR use ecore in <DIR>],
(B> > > < [ CFLAGS="$CFLAGS -I$withval/include"
(B> > > < LIBS="-L$withval/lib $LIBS"])
(B> > > < AC_ARG_WITH(edje,
(B> > > < [ --with-edje=DIR use edje in <DIR>],
(B> > > < [ CFLAGS="$CFLAGS -I$withval/include"
(B> > > < LIBS="-L$withval/lib $LIBS"])
(B> > > <
(B> > > < AC_PATH_GENERIC(edb, 1.0.3, [
(B> > > < AC_SUBST(edb_libs)
(B> > > < AC_SUBST(edb_cflags) ],
(B> > > < AC_MSG_ERROR(Cannot find edb: Is edb-config in path?))
(B> > > < edb_libs=`edb-config --libs`
(B> > > < edb_cflags=`edb-config --cflags`
(B> > > < AC_SUBST(edb_libs)
(B> > > ---
(B> > > > # EFL configuration
(B> > > > AC_ARG_WITH(edb-config,
(B> > > > [ --with-edb-config=EDB_CONFIG use edb-config
(B> > > > specified ],
(B> > > > [ EDB_CONFIG=$withval; echo "using "$EDB_CONFIG" for edb-config";
(B],
(B> > > > [ PROG="edb-config"; AC_PATH_PROG(EDB_CONFIG, $PROG, "", $PATH)
(B]
(B> > > > )
(B> > > > edb_cflags=`$EDB_CONFIG --cflags`
(B> > > > edb_libs=`$EDB_CONFIG --libs`
(B> > > 69,77c53,69
(B> > > <
(B> > > < AC_PATH_GENERIC(evas, 1.0.0, [
(B> > > < AC_SUBST(evas_libs)
(B> > > < AC_SUBST(evas_cflags) ],
(B> > > < AC_MSG_ERROR(Cannot find evas: Is evas-config in path?))
(B> > > < evas_libs=`evas-config --libs`
(B> > > < evas_cflags=`evas-config --cflags`
(B> > > <
(B> > > < AC_SUBST(evas_libs)
(B> > > ---
(B> > > > AC_SUBST(edb_libs)
(B> > > > AC_ARG_WITH(eet-config,
(B> > > > [ --with-eet-config=EET_CONFIG use eet-config
(B> > > > specified ],
(B> > > > [ EET_CONFIG=$withval; echo "using "$EET_CONFIG" for eet-config";
(B],
(B> > > > [ PROG="eet-config"; AC_PATH_PROG(EET_CONFIG, $PROG, "", $PATH)
(B]
(B> > > > )
(B> > > > eet_cflags=`$EET_CONFIG --cflags`
(B> > > > eet_libs=`$EET_CONFIG --libs`
(B> > > > AC_SUBST(eet_cflags)
(B> > > > AC_SUBST(eet_libs)
(B> > > > AC_ARG_WITH(evas-config,
(B> > > > [ --with-evas-config=EVAS_CONFIG use evas-config
(B> > > > specified ],
(B> > > > [ EVAS_CONFIG=$withval; echo "using "$EVAS_CONFIG" for evas-config";
(B ],
(B> > > > [ PROG="evas-config"; AC_PATH_PROG(EVAS_CONFIG, $PROG, "", $PATH)
(B ]
(B> > > > )
(B> > > > evas_cflags=`$EVAS_CONFIG --cflags`
(B> > > > evas_libs=`$EVAS_CONFIG --libs`
(B> > > 79,115c71,78
(B> > > <
(B> > > < have_ecore=no
(B> > > < AC_CHECK_HEADER(Ecore.h,,
(B> > > < AC_MSG_ERROR([Ecore.h not found! Have you installed Ecore?]))
(B> > > < AC_CHECK_LIB(ecore, ecore_list_new,
(B> > > < [have_ecore=yes],
(B> > > < AC_MSG_ERROR([Ecore check failed! Make sure you have the latest
(Bversion of Ecore installed.]))
(B> > > <
(B> > > < have_ecore_evas=no
(B> > > < AC_CHECK_HEADER(Ecore_Evas.h,,
(B> > > < AC_MSG_ERROR([Ecore_Evas.h not found! Did you compile Ecore with Evas
(Bsupport?]))
(B> > > <
(B> > > < AC_CHECK_LIB(ecore_evas, ecore_evas_init, [
(B> > > < have_ecore_evas=yes],
(B> > > < AC_MSG_ERROR([Cannot find Ecore_Evas!]))
(B> > > <
(B> > > < have_ecore_software_x11=no
(B> > > < AC_CHECK_LIB(ecore_evas, ecore_evas_software_x11_new, [
(B> > > < have_ecore_software_x11=yes],
(B> > > < AC_MSG_ERROR([Ecore_Evas does not have Software/X11 support!]))
(B> > > <
(B> > > < have_ecore_gl_x11=no
(B> > > < AC_CHECK_LIB(ecore_evas, ecore_evas_gl_x11_new, [
(B> > > < have_ecore_gl_x11=yes
(B> > > < AC_DEFINE(HAVE_ECORE_GL_X11, 1, [OpenGL support])])
(B> > > <
(B> > > < have_ecore_ipc=no
(B> > > < AC_CHECK_HEADER(Ecore_Ipc.h,,
(B> > > < AC_MSG_ERROR([Ecore_Ipc.h not found! Did you compile Ecore with IPC
(Bsupport?]))
(B> > > <
(B> > > < AC_CHECK_LIB(ecore_ipc, ecore_ipc_init, [
(B> > > < have_ecore_ipc=yes],
(B> > > < AC_MSG_ERROR([Cannot find Ecore_Ipc!]))
(B> > > <
(B> > > < ecore_cflags=`ecore-config --cflags`
(B> > > < ecore_libs=`ecore-config --libs`
(B> > > < AC_SUBST(ecore_libs)
(B> > > ---
(B> > > > AC_SUBST(evas_libs)
(B> > > > AC_ARG_WITH(ecore-config,
(B> > > > [ --with-ecore-config=ECORE_CONFIG use ecore-config
(B> > > > specified ],
(B> > > > [ ECORE_CONFIG=$withval; echo "using "$ECORE_CONFIG" for
(Becore-config"; ],
(B> > > > [ PROG="ecore-config"; AC_PATH_PROG(ECORE_CONFIG, $PROG, "", $PATH)
(B ]
(B> > > > )
(B> > > > ecore_cflags=`$ECORE_CONFIG --cflags`
(B> > > > ecore_libs=`$ECORE_CONFIG --libs`
(B> > > 117,124c80,87
(B> > > <
(B> > > < AC_PATH_GENERIC(edje, 0.5.0, [
(B> > > < AC_SUBST(edje_libs)
(B> > > < AC_SUBST(edje_cflags) ],
(B> > > < AC_MSG_ERROR(Cannot find edje: Is edje-config in path?))
(B> > > < edje_libs=`edje-config --libs`
(B> > > < edje_cflags=`edje-config --cflags`
(B> > > < AC_SUBST(edje_libs)
(B> > > ---
(B> > > > AC_SUBST(ecore_libs)
(B> > > > AC_ARG_WITH(edje-config,
(B> > > > [ --with-edje-config=EDJE_CONFIG use edje-config
(B> > > > specified ],
(B> > > > [ EDJE_CONFIG=$withval; echo "using "$EDJE_CONFIG" for edje-config";
(B ],
(B> > > > [ PROG="edje-config"; AC_PATH_PROG(EDJE_CONFIG, $PROG, "", $PATH)
(B ]
(B> > > > )
(B> > > > edje_cflags=`$EDJE_CONFIG --cflags`
(B> > > > edje_libs=`$EDJE_CONFIG --libs`
(B> > > 126,133c89,96
(B> > > <
(B> > > < AC_PATH_GENERIC(esmart, 0.9.0, [
(B> > > < AC_SUBST(esmart_libs)
(B> > > < AC_SUBST(esmart_cflags) ],
(B> > > < AC_MSG_ERROR(Cannot find esmart: Is esmart-config in path?))
(B> > > < esmart_libs=`esmart-config --libs`
(B> > > < esmart_cflags=`esmart-config --cflags`
(B> > > < AC_SUBST(esmart_libs)
(B> > > ---
(B> > > > AC_SUBST(edje_libs)
(B> > > > AC_ARG_WITH(esmart-config,
(B> > > > [ --with-esmart-config=ESMART_CONFIG use esmart-config
(B> > > > specified ],
(B> > > > [ ESMART_CONFIG=$withval; echo "using "$ESMART_CONFIG" for
(Besmart-config"; ],
(B> > > > [ PROG="esmart-config"; AC_PATH_PROG(ESMART_CONFIG, $PROG, "", $PATH)
(B ]
(B> > > > )
(B> > > > esmart_cflags=`$ESMART_CONFIG --cflags`
(B> > > > esmart_libs=`$ESMART_CONFIG --libs`
(B> > > 134a98
(B> > > > AC_SUBST(esmart_libs)
(B> > > 221a186,191
(B> > > > # Hack to show if OpenGL is included in evas
(B> > > > have_ecore_gl_x11=unknown
(B> > > > evas_gl_support="`evas-config --libs | grep GL`"
(B> > > > if test ! -z "$evas_gl_support" ; then
(B> > > > have_ecore_gl_x11=yes
(B> > > > fi
(B> > > Index: src/client/entrance_session.c
(B> > > ===================================================================
(B> > > RCS file:
(B/cvsroot/enlightenment/e17/apps/entrance/src/client/entrance_session.c,v
(B> > > retrieving revision 1.67
(B> > > diff -r1.67 entrance_session.c
(B> > > 38c38
(B> > > < char *db;
(B> > > ---
(B> > > > char *db, *str;
(B> > > 49,51c49,51
(B> > > < if (!display)
(B> > > < e->display = strdup(getenv("DISPLAY"));
(B> > > < else
(B> > > ---
(B> > > > if (!display) {
(B> > > > if ((str = getenv("DISPLAY"))) e->display = strdup(str);
(B> > > > } else
(B> > > Index: src/client/main.c
(B> > > ===================================================================
(B> > > RCS file: /cvsroot/enlightenment/e17/apps/entrance/src/client/main.c,v
(B> > > retrieving revision 1.69
(B> > > diff -r1.69 main.c
(B> > > 770,780c770,790
(B> > > < if (!session->config->engine)
(B> > > < e = ecore_evas_software_x11_new(NULL, 0, 0, 0, g_x, g_y);
(B> > > < #ifdef HAVE_ECORE_GL_X11
(B> > > < else if (session->config->engine)
(B> > > < e = ecore_evas_gl_x11_new(NULL, 0, 0, 0, g_x, g_y);
(B> > > < #endif
(B> > > < else
(B> > > < {
(B> > > < fprintf(stderr,
(B> > > < "Warning: Invalid Evas engine specified in config.
(BDefaulting to software engine.\n");
(B> > > < e = ecore_evas_software_x11_new(NULL, 0, 0, 0, g_x, g_y);
(B> > > ---
(B> > > > switch (session->config->engine) {
(B> > > > case 1:
(B> > > > if
(B> > > > (ecore_evas_engine_type_supported_get(ECORE_EVAS_ENGINE_GL_X11)) {
(B> > > > e = ecore_evas_gl_x11_new(NULL, 0, 0, 0, g_x, g_y);
(B> > > > break;
(B> > > > }
(B> > > > fprintf(stderr, "Warning: Evas GL engine: engine not
(B> > > > supported.
(BDefaulting to software engine.\n");
(B> > > >
(B> > > > case 0:
(B> > > > e = ecore_evas_software_x11_new(NULL, 0, 0, 0, g_x, g_y);
(B> > > > break;
(B> > > >
(B> > > > default:
(B> > > > fprintf(stderr, "Warning: Invalid Evas engine specified in
(B> > > > config.
(BDefaulting to software engine.\n");
(B> > > > e = ecore_evas_software_x11_new(NULL, 0, 0, 0, g_x, g_y);
(B> > > > break;
(B> > > > }
(B> > > >
(B> > > > if (!e) {
(B> > > > fprintf(stderr, "Critical error: No Evas engine available.
(BExiting.\n");
(B> > > > return (-1);
(B> >
(B> > __
(B> > Corey Donohoe
(B> > http://www.atmos.org
(B>
(B> --
(B>
(B> Ibukun Olumuyiwa
(B> http://xcomputerman.com
(B>
(B> "God is dead." - Nietzche
(B> "Nietzche is dead." - God
(B>
(B>
(B>
(B> -------------------------------------------------------
(B> SF email is sponsored by - The IT Product Guide
(B> Read honest & candid reviews on hundreds of IT Products from real users.
(B> Discover which products truly live up to the hype. Start reading now.
(B> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
(B> _______________________________________________
(B> enlightenment-devel mailing list
(B> [email protected]
(B> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
(B>
(B
(B
(B--
(B------------- Codito, ergo sum - "I code, therefore I am" --------------
(BThe Rasterman (Carsten Haitzler) [EMAIL PROTECTED]
$BMg9%B?(B [EMAIL PROTECTED]
(BTokyo, Japan ($BEl5~(B $BF|K\(B)
(B
(B
(B-------------------------------------------------------
(BSF email is sponsored by - The IT Product Guide
(BRead honest & candid reviews on hundreds of IT Products from real users.
(BDiscover which products truly live up to the hype. Start reading now.
(Bhttp://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
(B_______________________________________________
(Benlightenment-devel mailing list
([email protected]
(Bhttps://lists.sourceforge.net/lists/listinfo/enlightenment-devel
