Morten Nilsen wrote:
Phuah Yee Keat wrote:
http://www.geocities.com/kiwlm/entrance_xsession_additional.tar.gz
(with whatever bandwidth limit geocities have)
attached a patch against the tarball
1. I have copied the .desktop files from kdm verbatim, and install
them under PACKAGE_DATA_DIR
It is my personal oppinion that .desktop files should be installed by
each xsession providing package, and not be bundled with the login manager.
Yeah, that's the should-be case, but I have no Xsession .desktop files
on my system, besides for kde and gnome. So guess that its a best-case
to bundles in the .desktop files, until it become more standardized. :)
2. Entrance will now only have a configuration to where to look for
those .desktop files, currently they are stored in a comma separated
path list as '/entrance/sessions/dir'. Being a comma separated value
makes updates to this value harder though, maybe considering
'/entrance/sessions/dir/1', '/entrance/sessions/dir/2'?
like I already mentioned, why did you choose a non-standard path separator?
This is solely following KDM's configuration of separating items in the
configuration value, can be changed to the path separator. :)
3. I have added some defaults (from my own consensus) and also the
location that enlightenment would install its enlightenment.desktop if
enlightenment is using the same --prefix as entrance is. I have found
nothing from google about where these XSession .desktop files should
reside, Application .desktop files should go into
/usr/share/applications though...
I would make the default desktop-folder a configure option..
--xsession-dir=/usr/share/xsessions
Sounds good, but I think we need to add in our own as well, and the
comma/colon separated path does not support this type of
addition/removal of entries easily. Is there some sort of "list" support
in ecore_config that does not requires explicit numbering and counting?
4. Entrance would try to look for the executable as specified in
TryExec in the desktop file, in the PATH environment variable, as KDM
would have done it.
sounds fine to me
5. Since KDM's .desktop files does not have "Icon" parameters, none of
the entries have default Icons, so I made an addition to check if
entrance have the icon files installed, kde.png, enlightenment.png,
gnome.png...
another reason not to bundle a score of desktop files ;)
enlightenment.desktop that comes in e17 does not have a Icon parameter
as well! lol.
Cheers,
Phuah Yee Keat
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
