I can't reproduce that root owner ship issue right now. I made the changes to my scripts on the 2017/08/17 at that time on my archlinux boxes ninja was 1.7.2 and meson was 0.41.2 since then ninja has been upgraded to 1.8.2, and meson to 0.42.1 then 0.43.0 maybe it has been fixed in one of them fixed now. (but I won't dive into their respective repos to check that ;)
On Wednesday 22 November 2017 20:51, Carsten Haitzler wrote : > On Wed, 22 Nov 2017 10:36:36 +0000 Andrew Williams <a...@andywilliams.me> > said: > > > Hi, > > > > I'm glad that it is not affecting you. Jeyzu and I both seem to have hit > > this issue (and I guess zmike too as described earlier). > > Some times after a "sudo ninja install" I can no longer "ninja" due to > > permissions issues with files that have become root owned. > > > > It is unfortunate but it would be good to get a solution that works all the > > time for everyone if possible. > > I checked what files were root owned. I currently don't see a reason why it > should fail. Someone show me a reason where it does fail (a file written to as > root has to be overwritten as a user or it cannot be deleted as a user). I > don't see it. perhaps its a bug in meson in an older version? or a newer one? > > > Andy > > > > On Wed, 22 Nov 2017 at 10:17 Carsten Haitzler <ras...@rasterman.com> wrote: > > > > > On Wed, 22 Nov 2017 10:33:05 +0100 Jérémy Zurcher <jer...@asynk.ch> said: > > > > > > > Hi, > > > > > > > > I confirm, I had to add the above in my build script : > > > > > > > > sudo -S chown $USER $BUILD_DIR/.ninja_deps $BUILD_DIR/.ninja_log > > > > > > 7:14PM ~/C/e/build ⎇ master > ls -al > > > total 4.4M > > > 4.0K drwxr-xr-x 9 raster raster 4.0K Nov 22 15:36 ./ > > > 4.0K drwxr-xr-x 10 raster raster 4.0K Nov 22 15:36 ../ > > > 1.6M -rw-r--r-- 1 raster raster 1.6M Nov 22 15:36 .ninja_deps > > > 64K -rw-r--r-- 1 raster raster 61K Nov 22 15:36 .ninja_log > > > > > > written not as root. (make ninja install was as root). ... ? > > > > > > > On Wednesday 22 November 2017 08:18, Andrew Williams wrote : > > > > > Hi, > > > > > > > > > > Compiling as root may be a bad thing but mike is right, ninja install > > > hits > > > > > log files and other - some times causing root ownership. I have seen > > > > > it > > > > > occasionally myself and have had to either delete the build tree or > > > chown > > > > > it to myself. > > > > > > > > > > Perhaps this is a bug we should be reporting but in the meantime our > > > docs > > > > > should cover it somehow. > > > > > > > > > > Andy > > > > > On Wed, 22 Nov 2017 at 00:19, Carsten Haitzler <ras...@rasterman.com> > > > wrote: > > > > > > > > > > > On Tue, 21 Nov 2017 16:37:09 +0000 Mike Blumenkrantz > > > > > > <michael.blumenkra...@gmail.com> said: > > > > > > > > > > > > > The wording is intentional. The meson build has a tendency to > > > > > > > touch > > > > > > > build files during the install phase (which must be run as root to > > > > > > > install to > > > > > > the > > > > > > > base system), meaning that failure to use sudo during general > > > build will > > > > > > > fail for subsequent builds anyway due to permissions errors when > > > > > > attempting > > > > > > > to modify root-owned files. > > > > > > > > > > > > i have never had a permission error after a "sudo ninja install" to > > > just > > > > > > run > > > > > > ninja as me to rebuild whatever changed. it's just the gmo files > > > > > > (and > > > > > > install > > > > > > log which obviously is written as root) from gettext... and they are > > > only > > > > > > re-generated by root so ... root overwrites root files. you can > > > delete > > > > > > these > > > > > > files because they are in a directory owned by you (the user). > > > > > > > > > > > > so where is the actual permission problem? a ninja && sudo ninja > > > install > > > > > > will > > > > > > succeed without permission problems (see above). you as a user can > > > delete > > > > > > the > > > > > > effected files too. > > > > > > > > > > > > but suggestion people compile as root is a bad idea. > > > > > > > > > > > > ??? > > > > > > > > > > > > > On Mon, Nov 20, 2017 at 8:14 PM Carsten Haitzler < > > > ras...@rasterman.com> > > > > > > > wrote: > > > > > > > > > > > > > > > On Mon, 20 Nov 2017 15:04:48 +0000 Mike Blumenkrantz > > > > > > > > <michael.blumenkra...@gmail.com> said: > > > > > > > > > > > > > > > > > Issues had been found at an inconvenient time during review, > > > so I > > > > > > left > > > > > > > > the > > > > > > > > > branch unmerged so that someone could either push while I was > > > gone > > > > > > or I > > > > > > > > > could push when I returned. > > > > > > > > > > > > > > > > I saw you pushed now. so we know the status. This also clears up > > > the > > > > > > build > > > > > > > > system state. I guess I should ensure it's documented. I see > > > README > > > > > > > > changed but > > > > > > > > i am not sure it's correct as it's going to do a build as > > > root... i'll > > > > > > deal > > > > > > > > with it. :) > > > > > > > > > > > > > > > > > On Sun, Nov 19, 2017 at 6:56 PM Carsten Haitzler < > > > > > > ras...@rasterman.com> > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > On Sun, 19 Nov 2017 13:05:06 +0000 Andrew Williams < > > > > > > > > a...@andywilliams.me> > > > > > > > > > > said: > > > > > > > > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > > > > > > > As the autotool/Makefiles are still in place I fixed the > > > build > > > > > > for > > > > > > > > users > > > > > > > > > > > not yet using the E meson build. > > > > > > > > > > > > > > > > > > > > i was assuming autotools was dead - mike did say he'd push > > > his > > > > > > > > autotools > > > > > > > > > > removal branch "in a day or 2 if no issues"... that about > > > > > > > > > > 1-2 > > > > > > > > > > weeks > > > > > > > > back. i > > > > > > > > > > didn't see it happen and didn't hear of issues... > > > > > > > > > > > > > > > > > > > > are there any? I'd consider merging his branch to remove > > > autofoo > > > > > > > > > > at > > > > > > > > this > > > > > > > > > > point. > > > > > > > > > > If meson has issues it should be tested and they should be > > > fixed. > > > > > > > > > > > > > > > > > > > > > Andy > > > > > > > > > > > > > > > > > > > > > > On Fri, 17 Nov 2017 at 03:19 Carsten Haitzler < > > > > > > ras...@rasterman.com> > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > raster pushed a commit to branch master. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > http://git.enlightenment.org/core/enlightenment.git/commit/?id=f4d2d02ba0f15b7f36e7de61141ff88c145f5630 > > > > > > > > > > > > > > > > > > > > > > > > commit f4d2d02ba0f15b7f36e7de61141ff88c145f5630 > > > > > > > > > > > > Author: Carsten Haitzler (Rasterman) < > > > ras...@rasterman.com> > > > > > > > > > > > > Date: Fri Nov 17 12:17:42 2017 +0900 > > > > > > > > > > > > > > > > > > > > > > > > music-control - install properly with meson build > > > with > > > > > > > > > > > > icon > > > > > > > > > > > > > > > > > > > > > > > > @fix > > > > > > > > > > > > --- > > > > > > > > > > > > ...-module-music_control.edj => > > > e-module-music-control.edj} | > > > > > > Bin > > > > > > > > > > > > src/modules/music-control/meson.build > > > > > > | 2 > > > > > > > > -- > > > > > > > > > > > > src/modules/music-control/module.desktop > > > > > > | 2 > > > > > > > > +- > > > > > > > > > > > > 3 files changed, 1 insertion(+), 3 deletions(-) > > > > > > > > > > > > > > > > > > > > > > > > diff --git > > > > > > a/src/modules/music-control/e-module-music_control.edj > > > > > > > > > > > > b/src/modules/music-control/e-module-music-control.edj > > > > > > > > > > > > similarity index 100% > > > > > > > > > > > > rename from > > > > > > src/modules/music-control/e-module-music_control.edj > > > > > > > > > > > > rename to > > > src/modules/music-control/e-module-music-control.edj > > > > > > > > > > > > diff --git a/src/modules/music-control/meson.build > > > > > > > > > > > > b/src/modules/music-control/meson.build > > > > > > > > > > > > index 996b4196f..a84f5ea8e 100644 > > > > > > > > > > > > --- a/src/modules/music-control/meson.build > > > > > > > > > > > > +++ b/src/modules/music-control/meson.build > > > > > > > > > > > > @@ -18,5 +18,3 @@ src += custom_target('gen-dbus', > > > > > > > > > > > > command: [eldbus_codegen, '@INPUT@ > > > ', > > > > > > '-O', > > > > > > > > > > '@OUTDIR@ > > > > > > > > > > > > '], > > > > > > > > > > > > output : created_file > > > > > > > > > > > > ) > > > > > > > > > > > > - > > > > > > > > > > > > -no_icon = true > > > > > > > > > > > > diff --git a/src/modules/music-control/module.desktop > > > > > > > > > > > > b/src/modules/music-control/module.desktop > > > > > > > > > > > > index 99a2d9143..2e12677e3 100644 > > > > > > > > > > > > --- a/src/modules/music-control/module.desktop > > > > > > > > > > > > +++ b/src/modules/music-control/module.desktop > > > > > > > > > > > > @@ -27,5 +27,5 @@ Comment[nl]=Beheers uw muziek op uw > > > plank > > > > > > > > > > > > Comment[ru]=Модуль для управления воспроизведением > > > музыки > > > > > > > > > > > > Comment[sr]=Управљајте музиком са полице > > > > > > > > > > > > Comment[tr]=Müziğinizi rafta kontrol edin > > > > > > > > > > > > -Icon=e-module-music_control > > > > > > > > > > > > +Icon=e-module-music-control > > > > > > > > > > > > X-Enlightenment-ModuleType=utils > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > http://andywilliams.me > > > > > > > > > > > http://ajwillia.ms > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------------ > > > > > > > > > > > Check out the vibrant tech community on one of the world's > > > most > > > > > > > > > > > engaging tech sites, Slashdot.org! > > > http://sdm.link/slashdot > > > > > > > > > > > _______________________________________________ > > > > > > > > > > > enlightenment-devel mailing list > > > > > > > > > > > enlightenment-devel@lists.sourceforge.net > > > > > > > > > > > > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > ------------- Codito, ergo sum - "I code, therefore I am" > > > > > > > > -------------- > > > > > > > > > > Carsten Haitzler - ras...@rasterman.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------------ > > > > > > > > > > Check out the vibrant tech community on one of the world's > > > most > > > > > > > > > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > > > > > > > > > _______________________________________________ > > > > > > > > > > enlightenment-devel mailing list > > > > > > > > > > enlightenment-devel@lists.sourceforge.net > > > > > > > > > > > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------------ > > > > > > > > > Check out the vibrant tech community on one of the world's > > > > > > > > > most > > > > > > > > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > > > > > > > > _______________________________________________ > > > > > > > > > enlightenment-devel mailing list > > > > > > > > > enlightenment-devel@lists.sourceforge.net > > > > > > > > > > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > ------------- Codito, ergo sum - "I code, therefore I am" > > > > > > -------------- > > > > > > > > Carsten Haitzler - ras...@rasterman.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > ------------- Codito, ergo sum - "I code, therefore I am" > > > -------------- > > > > > > Carsten Haitzler - ras...@rasterman.com > > > > > > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------------ > > > > > > Check out the vibrant tech community on one of the world's most > > > > > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > > > > > _______________________________________________ > > > > > > enlightenment-devel mailing list > > > > > > enlightenment-devel@lists.sourceforge.net > > > > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > > > > -- > > > > > http://andywilliams.me > > > > > http://ajwillia.ms > > > > > > > > ------------------------------------------------------------------------------ > > > > > Check out the vibrant tech community on one of the world's most > > > > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > > > > _______________________________________________ > > > > > enlightenment-devel mailing list > > > > > enlightenment-devel@lists.sourceforge.net > > > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > --- Hell'O from Yverdoom > > > > > > > > Jérémy (jeyzu) > > > > > > > > > > > ------------------------------------------------------------------------------ > > > > Check out the vibrant tech community on one of the world's most > > > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > > > _______________________________________________ > > > > enlightenment-devel mailing list > > > > enlightenment-devel@lists.sourceforge.net > > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > > -- > > > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > > > Carsten Haitzler - ras...@rasterman.com > > > > > > > > > > > > ------------------------------------------------------------------------------ > > > Check out the vibrant tech community on one of the world's most > > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > > _______________________________________________ > > > enlightenment-devel mailing list > > > enlightenment-devel@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > -- > > http://andywilliams.me > > http://ajwillia.ms > > ------------------------------------------------------------------------------ > > Check out the vibrant tech community on one of the world's most > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > Carsten Haitzler - ras...@rasterman.com > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel --- Hell'O from Yverdoom Jérémy (jeyzu) ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
