Here is one both Coverity and Sonar miss, also clangs scan-build. Likely
something valgrind would catch/show.

This is never free'd, not anywhere I can tell. Though I could be wrong.

 _login = strdup(login);
https://github.com/Obsidian-StudiosInc/entrance/blob/master/src/daemon/entrance_session.c#L335

Even in orig
https://git.enlightenment.org/misc/entrance.git/tree/src/daemon/entrance_session.c#n301

I added another strdup to fix an issue.
https://github.com/Obsidian-StudiosInc/entrance/blob/master/src/daemon/entrance_session.c#L404

Sonar did not pick that up, nor clang's scan-build. No longer using
Coverity, but seems it would not catch it either as it did not before.

Just goes to show one can only rely on the scanners so much. They fail
even on valid detection of some things.


-- 
William L. Thomson Jr.

Attachment: pgpzMwdQj_qdl.pgp
Description: OpenPGP digital signature

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to