On Tue, Apr 28, 2020, at 12:12, Stefan Schmidt wrote: > Hello Dave. > > On 27.04.20 19:13, Davide Andreoli wrote: > > What about cleaning the build warnings for the release? > > I'm getting this ones on latest git: > > > > [1806/2261] Compiling C object 'src/lib/elementary/f70ca57@@elementary@sha > >> /efl_ui_widget.c.o'. > >> In file included from ../src/lib/elementary/efl_ui_widget.c:5701: > >> src/lib/elementary/efl_ui_widget_part.eo.c: In function > >> ‘__eolian_efl_ui_widget_part_efl_gfx_entity_scale_set’: > >> src/lib/elementary/efl_ui_widget_part.eo.c:49:125: warning: unused > >> parameter ‘scale’ [-Wunused-parameter] > >> 49 | static void > >> __eolian_efl_ui_widget_part_efl_gfx_entity_scale_set(Eo *obj EINA_UNUSED, > >> Elm_Part_Data *pd EINA_UNUSED, double scale) > >> | > >> ~~~~~~~^~~~~ > >> [1829/2261] Compiling C object 'src/lib/elementary/f70ca57@@elementary@sha > >> /efl_ui_view_model.c.o'. > >> In file included from ../src/lib/elementary/efl_ui_view_model.c:859: > >> src/lib/elementary/efl_ui_view_model.eo.c: In function > >> ‘_efl_ui_view_model_property_logic_add_ownership_fallback’: > >> src/lib/elementary/efl_ui_view_model.eo.c:13:86: warning: unused parameter > >> ‘get_data’ [-Wunused-parameter] > >> 13 | _efl_ui_view_model_property_logic_add_ownership_fallback(const > >> char *property, void *get_data, EflUiViewModelPropertyGet get, Eina_Free_Cb > >> get_free_cb, void *set_data, EflUiViewModelPropertySet set, Eina_Free_Cb > >> set_free_cb, Eina_Iterator *bound) > >> | > >> ~~~~~~^~~~~~~~ > >> src/lib/elementary/efl_ui_view_model.eo.c:13:140: warning: unused > >> parameter ‘get_free_cb’ [-Wunused-parameter] > >> 13 | _efl_ui_view_model_property_logic_add_ownership_fallback(const > >> char *property, void *get_data, EflUiViewModelPropertyGet get, Eina_Free_Cb > >> get_free_cb, void *set_data, EflUiViewModelPropertySet set, Eina_Free_Cb > >> set_free_cb, Eina_Iterator *bound) > >> | > >> > >> ~~~~~~~~~~~~~^~~~~~~~~~~ > >> src/lib/elementary/efl_ui_view_model.eo.c:13:159: warning: unused > >> parameter ‘set_data’ [-Wunused-parameter] > >> 13 | _efl_ui_view_model_property_logic_add_ownership_fallback(const > >> char *property, void *get_data, EflUiViewModelPropertyGet get, Eina_Free_Cb > >> get_free_cb, void *set_data, EflUiViewModelPropertySet set, Eina_Free_Cb > >> set_free_cb, Eina_Iterator *bound) > >> | > >> > >> ~~~~~~^~~~~~~~ > >> src/lib/elementary/efl_ui_view_model.eo.c:13:213: warning: unused > >> parameter ‘set_free_cb’ [-Wunused-parameter] > >> 13 | _efl_ui_view_model_property_logic_add_ownership_fallback(const > >> char *property, void *get_data, EflUiViewModelPropertyGet get, Eina_Free_Cb > >> get_free_cb, void *set_data, EflUiViewModelPropertySet set, Eina_Free_Cb > >> set_free_cb, Eina_Iterator *bound) > >> | > >> > >> > >> ~~~~~~~~~~~~~^~~~~~~~~~~ > >> > > > > They seems easy to fix and they give a bad impression on a stable release > > Its a fair point. As Xavi mentioned already this comes from generated > code. I will talk to Daniel to see if we can get this fixed in time for > the release.
I fixed these specific cases. To do it better bigger refactoring/rewriting will be needed but that's not something to do a day before release > > regards > Stefan Schmidt > > > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
