Totally agreed. That's generated code, though. Xavi
On Mon, 27 Apr 2020 at 19:15, Davide Andreoli <d...@gurumeditation.it> wrote: > What about cleaning the build warnings for the release? > I'm getting this ones on latest git: > > [1806/2261] Compiling C object 'src/lib/elementary/f70ca57@@elementary@sha > > /efl_ui_widget.c.o'. > > In file included from ../src/lib/elementary/efl_ui_widget.c:5701: > > src/lib/elementary/efl_ui_widget_part.eo.c: In function > > ‘__eolian_efl_ui_widget_part_efl_gfx_entity_scale_set’: > > src/lib/elementary/efl_ui_widget_part.eo.c:49:125: warning: unused > > parameter ‘scale’ [-Wunused-parameter] > > 49 | static void > > __eolian_efl_ui_widget_part_efl_gfx_entity_scale_set(Eo *obj EINA_UNUSED, > > Elm_Part_Data *pd EINA_UNUSED, double scale) > > | > > ~~~~~~~^~~~~ > > [1829/2261] Compiling C object 'src/lib/elementary/f70ca57@ > @elementary@sha > > /efl_ui_view_model.c.o'. > > In file included from ../src/lib/elementary/efl_ui_view_model.c:859: > > src/lib/elementary/efl_ui_view_model.eo.c: In function > > ‘_efl_ui_view_model_property_logic_add_ownership_fallback’: > > src/lib/elementary/efl_ui_view_model.eo.c:13:86: warning: unused > parameter > > ‘get_data’ [-Wunused-parameter] > > 13 | _efl_ui_view_model_property_logic_add_ownership_fallback(const > > char *property, void *get_data, EflUiViewModelPropertyGet get, > Eina_Free_Cb > > get_free_cb, void *set_data, EflUiViewModelPropertySet set, Eina_Free_Cb > > set_free_cb, Eina_Iterator *bound) > > | > > ~~~~~~^~~~~~~~ > > src/lib/elementary/efl_ui_view_model.eo.c:13:140: warning: unused > > parameter ‘get_free_cb’ [-Wunused-parameter] > > 13 | _efl_ui_view_model_property_logic_add_ownership_fallback(const > > char *property, void *get_data, EflUiViewModelPropertyGet get, > Eina_Free_Cb > > get_free_cb, void *set_data, EflUiViewModelPropertySet set, Eina_Free_Cb > > set_free_cb, Eina_Iterator *bound) > > | > > > > ~~~~~~~~~~~~~^~~~~~~~~~~ > > src/lib/elementary/efl_ui_view_model.eo.c:13:159: warning: unused > > parameter ‘set_data’ [-Wunused-parameter] > > 13 | _efl_ui_view_model_property_logic_add_ownership_fallback(const > > char *property, void *get_data, EflUiViewModelPropertyGet get, > Eina_Free_Cb > > get_free_cb, void *set_data, EflUiViewModelPropertySet set, Eina_Free_Cb > > set_free_cb, Eina_Iterator *bound) > > | > > > > ~~~~~~^~~~~~~~ > > src/lib/elementary/efl_ui_view_model.eo.c:13:213: warning: unused > > parameter ‘set_free_cb’ [-Wunused-parameter] > > 13 | _efl_ui_view_model_property_logic_add_ownership_fallback(const > > char *property, void *get_data, EflUiViewModelPropertyGet get, > Eina_Free_Cb > > get_free_cb, void *set_data, EflUiViewModelPropertySet set, Eina_Free_Cb > > set_free_cb, Eina_Iterator *bound) > > | > > > > > > ~~~~~~~~~~~~~^~~~~~~~~~~ > > > > They seems easy to fix and they give a bad impression on a stable release > just my 2 cents > Dave > > > Il giorno lun 27 apr 2020 alle ore 16:15 Stefan Schmidt < > ste...@datenfreihafen.org> ha scritto: > > > Hello. > > > > I just uploaded another run for current git master. > > > > > > > http://www.enlightenment.org/~stefan/abi-tracker/objects_report/efl/1.24.0-beta3/current/report.html > > > > This looks good for the changes from beta3 to current. > > > > If anyone wants to do another review this would be the last chance to do > > so as I am planning to do the final release on Wednesday. > > > > regards > > Stefan Schmidt > > > > > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
