On 5/29/07, Brian Mattern <[EMAIL PROTECTED]> wrote: > Along with the GROUP part support I committed over the weekend, came a > slight change to edje_object_part_swallow(). This function will now ONLY > operate on SWALLOW parts. If you try to swallow into e.g. a RECT, it > will fail.
I really like this, being more strict is always good and help beginners like I was some weeks ago to read themes... I was always confused by this. Also, I'm pro to always require a TYPE, or at least warn on missing type instead of default to IMAGE. > Unfortunately, the API currently does not return a status on whether the > swallow succeeded (i.e. the part existed and was of type SWALLOW) or > not. Maybe we can change this later to return 1 on success and 0 > otherwise? I'm fine with this too, and since it won't break backward compat, why not? > There has been at least one report of a broken theme due to this ("empty > menus"). The fix is to simply change any parts that get swallowed into > to the correct type (for e17 themes, they SHOULD all be named > e.swallow.*, so checking a theme for correctness isn't too difficult). yep -- Gustavo Sverzut Barbieri -------------------------------------- Jabber: [EMAIL PROTECTED] MSN: [EMAIL PROTECTED] ICQ#: 17249123 Skype: gsbarbieri Mobile: +55 (81) 9927 0010 ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel