On Sat, 17 Nov 2007 11:11:55 -0600 "Nathan Ingersoll" <[EMAIL PROTECTED]>
babbled:
> Is this a proper fix or hiding a bug in the calling application (or
> another part of the lib)? I would think the application should be
> responsible of knowing when they should unref the connection.
personally i like defensive programming. it's better than every process having
to trap its segv's/aborts and give u a debug trace and suddenly lose all your
work/state. i think a compile or runtime definable "please btich to stdout/err
about these problems" is the best way to go (all of evas and ecore are very
defensively programmed - set environment variables to turn on "bitch mode" and
you can also enable "abort mode" for aborting on caught failures).
> On 11/16/07, Enlightenment CVS <[EMAIL PROTECTED]> wrote:
> > Enlightenment CVS committal
> >
> > Author : ravenlock
> > Project : e17
> > Module : libs/e_dbus
> >
> > Dir : e17/libs/e_dbus/src/lib/dbus
> >
> >
> > Modified Files:
> > e_dbus.c
> >
> >
> > Log Message:
> > Ive gotten a segfault or two here.
> >
> > ===================================================================
> > RCS file: /cvs/e/e17/libs/e_dbus/src/lib/dbus/e_dbus.c,v
> > retrieving revision 1.2
> > retrieving revision 1.3
> > diff -u -3 -r1.2 -r1.3
> > --- e_dbus.c 4 Nov 2007 07:51:36 -0000 1.2
> > +++ e_dbus.c 17 Nov 2007 03:26:08 -0000 1.3
> > @@ -548,6 +548,7 @@
> > EAPI void
> > e_dbus_connection_unref(E_DBus_Connection *conn)
> > {
> > + if (!conn) return;
> > if (--(conn->refcount) == 0) e_dbus_connection_close(conn);
> > }
> >
> >
> >
> >
> > -------------------------------------------------------------------------
> > This SF.net email is sponsored by: Microsoft
> > Defy all challenges. Microsoft(R) Visual Studio 2005.
> > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> > _______________________________________________
> > enlightenment-cvs mailing list
> > [EMAIL PROTECTED]
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
> >
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2005.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler) [EMAIL PROTECTED]
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
