On Tue, May 13, 2008 at 5:51 PM, Gustavo Sverzut Barbieri <[EMAIL PROTECTED]> wrote: > On Tue, May 13, 2008 at 5:20 PM, Diego Bitencourt Contezini > <[EMAIL PROTECTED]> wrote: >> Hello all. >> Working with evas+Lines in python, is fast. But if you need a line with more >> then one pixel of width, it gets very slow (in dispositives like N800), >> because object Line dont have width support, so its needen to use Rectangles >> to make it works. >> >> I made a modification to support width in Lines object. It is composed by 3 >> patchs. >> *First*, in evas/lib/*, it changes internal call to engine line drawer, >> inserting more one argument to the same function. It is a callback, so, no >> modification is needen in any engine module that dosnt support Lines with >> more then 1 pixel (they will just draw with only 1 pixel). Has added new >> functions to deal with width, without breaking any compatibility of other >> functions. >> *Second*, in evas/engine/software16 to add support to width. >> *Third,* in python-evas binding, to add support to use the modifications >> made in evas. >> >> If anyone get any bug or suggest any modification to patch, im a listener. > > Hi, > > I have no time to look at this now, but when we required lines with > > 1px width we used polygons with great success. > > Actually, I guess it's difficult to see single lines being used > separated, often we use connected lines, in this case it would be > great to be able to choose the caps/join to be used... using polygons > users can implement this. > > Of course creating the polygons are bit hard, so having this ready in > Evas would help a lot :-) > > -- > Gustavo Sverzut Barbieri > http://profusion.mobi embedded systems > -------------------------------------- > MSN: [EMAIL PROTECTED] > Skype: gsbarbieri > Mobile: +55 (19) 9225-2202
Hi Diego, We use polygons to trace routes and other things too. I suggest you to send some benchmarks to the list showing the benefits of this patch with some use cases. With this in hand is better to apply your patch. Gustavo is one of the most indicated people to judge and apply your patch due the fact it's used with software 16 engine. I didn't have time to test it yet but one thing that I noted is that you are changing the line_draw signature and this will break the API breaking some applications in consequence. So it would be better to create another method that draw a line with specified width. Adriano Rezende ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
