On Mon, May 19, 2008 at 6:39 AM, Enlightenment CVS
<[EMAIL PROTECTED]> wrote:
> Enlightenment CVS committal
>
> Author : devilhorns
> Project : e17
> Module : apps/e
>
> Dir : e17/apps/e/src/modules/gadman
>
>
> Modified Files:
> e_mod_gadman.c e_mod_gadman.h e_mod_main.c
>
>
> Log Message:
> Cleanup compiler warnings.
>
> ===================================================================
> RCS file: /cvs/e/e17/apps/e/src/modules/gadman/e_mod_gadman.c,v
> retrieving revision 1.2
> retrieving revision 1.3
> diff -u -3 -r1.2 -r1.3
> --- e_mod_gadman.c 19 May 2008 09:21:44 -0000 1.2
> +++ e_mod_gadman.c 19 May 2008 09:39:37 -0000 1.3
> - return &b;
> + return strdup(b);
> }
> return "(You must define a binding)";
boing! you need to strdup() "(You must...)" and I hope you're
free()ing it as well...
===================================================================
> RCS file: /cvs/e/e17/apps/e/src/modules/gadman/e_mod_gadman.h,v
> retrieving revision 1.1
> retrieving revision 1.2
> diff -u -3 -r1.1 -r1.2
> --- e_mod_gadman.h 19 May 2008 04:37:34 -0000 1.1
> +++ e_mod_gadman.h 19 May 2008 09:39:37 -0000 1.2
> @@ -20,7 +20,7 @@
> Evas_Object *mover;
> Evas_Object *mover_top;
> Evas_Object *full_bg;
> - char *icon_name;
> + const char *icon_name;
>
> int visible;
> int use_composite;
> ===================================================================
> RCS file: /cvs/e/e17/apps/e/src/modules/gadman/e_mod_main.c,v
> retrieving revision 1.2
> retrieving revision 1.3
> diff -u -3 -r1.2 -r1.3
> --- e_mod_main.c 19 May 2008 09:21:44 -0000 1.2
> +++ e_mod_main.c 19 May 2008 09:39:37 -0000 1.3
> @@ -41,8 +41,9 @@
> /* Menu augmentation */
> Man->icon_name = evas_stringshare_add(buf);
> Man->maug = NULL;
> - Man->maug = e_int_menus_menu_augmentation_add("config/1",
> _gadman_maug_add,
> - Man->icon_name, NULL, NULL);
> + Man->maug =
> + e_int_menus_menu_augmentation_add("config/1", _gadman_maug_add,
> + (void *)Man->icon_name, NULL, NULL);
(void *) is not that good here... maybe we could change the e_int_...
to take a const void * there? Internally it could cast when
dispatching, for easy of use.
--
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--------------------------------------
MSN: [EMAIL PROTECTED]
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
