On Tue, Apr 21, 2009 at 6:55 AM, Enlightenment SVN <no-re...@enlightenment.org> wrote: > Log: > Fix compiler warnings about attribute warn_unused_result
> - evas_object_key_grab(o, "Tab", mask, ~mask, 0); > + kg = evas_object_key_grab(o, "Tab", mask, ~mask, 0); this is bad, don't remove warnings just for the sake. When I added WARN_UNUSED_RESULT to evas_object_key_grab() I did think that it should be handled, but I'm no expert there. In any case, either do proper checking if required or remove EINA_WARN_UNUSED_RESULT from the function signature, but don't do this... since we later realize that we should really handle the result, we'd have hard time trying to figure out where these buggers are :-( -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ Stay on top of everything new and different, both inside and around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. 300 plus technical and hands-on sessions. Register today. Use priority code J9JMT32. http://p.sf.net/sfu/p _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
