On Tue, Apr 21, 2009 at 11:39 AM, Massimiliano Calamelli <mcalame...@gmail.com> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On Tue, 21 Apr 2009 10:20:27 -0300 > Gustavo Sverzut Barbieri <barbi...@profusion.mobi> wrote: >> >> this is bad, don't remove warnings just for the sake. When I added >> WARN_UNUSED_RESULT to evas_object_key_grab() I did think that it >> should be handled, but I'm no expert there. >> >> In any case, either do proper checking if required or remove >> EINA_WARN_UNUSED_RESULT from the function signature, but don't do >> this... since we later realize that we should really handle the >> result, we'd have hard time trying to figure out where these buggers >> are :-( >> > > I know, but after a search I didn't found a proper way to notify an > error. Now, I think that we can do that: > > Ex: > > kg = evas_object_key_grab(o, "Tab", mask, ~mask, 0); > if (!kg) > fprintf(stderr, > "ERROR: unable to redirect \"Tab\" key events to object %p.\n",o); > kg = evas_object_key_grab(o, "Return", mask, ~mask, 0); > if (!kg) > printf(stderr, > "ERROR: unable to redirect \"Return\" key events to object %p.\n",o); > mask = 0; kg = evas_object_key_grab(o, "KP_Enter", mask, ~mask, 0); > if (!kg) > fprintf(stderr, > "ERROR: unable to redirect \"KP_Enter\" key events to object %p. > \n",o); > > > What do you think about?
yeah, either that or start using EINA_PERROR macros. They're not much used in e17, but could be so we could turn off debugging if we wish. One thing that eina misses is debugging namespaces, so you could turn off e debug but leave eina's, or turn off eina's and leave e. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ Stay on top of everything new and different, both inside and around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. 300 plus technical and hands-on sessions. Register today. Use priority code J9JMT32. http://p.sf.net/sfu/p _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
