On Fri, Jul 17, 2009 at 7:35 PM, Andre Dieb<andre.mart...@ee.ufcg.edu.br> wrote: > I'd also suggest renaming the env var EINA_ERROR_DOMAIN_LEVELS to > EINA_ERROR_LEVELS. It's smaller and more compatible with the global one > (EINA_ERROR_LEVEL). >
+ // Did not found a slot, realloc 8 more slots. Also works on the first time + // when the array doesn't exist yet. + _error_domains = realloc(_error_domains, sizeof(Eina_Error_Domain)*8); Watch out here, if realloc fails, you lose your current pointer. Also, since _error_domains is an array of pointers, you want sizeof(Eina_Error_Domain *) > > On Fri, Jul 17, 2009 at 6:55 PM, Andre Dieb > <andre.mart...@ee.ufcg.edu.br>wrote: > >> Hello, >> >> This patch contains an initial implementation of logging domains for eina >> error module. Please be aware that this a very rough version and there are >> lots of things that must be improved. >> >> The patch is also with lots of fprintf's that I was using for debugging, >> please ignore them. When we're ready to apply, I'll cleanup everything. >> >> For testing the new domain features, I added three unit tests and fixed >> eina_rectangle test that was preventing me from building eina_error test. >> You can also see examples of how logging domains will be used on these tests >> (registering, logging, unregistering). >> >> There are also a few things that I wasn't sure and I'd really appreciate >> some help: >> >> - Logging priorities (EINA_ERROR_LEVEL and domain level): is the code >> with the correct priorities? (lines 1064 to 1071 of eina_error.c) >> - Domain slots: from the tests results, it looks like the slot code is >> working, but I'm not sure it doesn't have a case which will break >> - Levels: is INT32_MAX a good value for the UNKNOWN level (which is >> basically just a placeholder. Whenever you log and it's UNKNOWN, your >> domain >> will use global level) >> - Old API: I redirected the old API to a global logger which is >> registered on eina_error_init(). Is this OK? >> >> >> -- >> André Dieb Martins >> >> Embedded Systems and Pervasive Computing Lab (Embedded) >> Electrical Engineering Department (DEE) >> Center of Electrical Engineering and Informatics (CEEI) >> Federal University of Campina Grande (UFCG) >> >> Blog: http://genuinepulse.blogspot.com/ >> > > > > -- > André Dieb Martins > > Embedded Systems and Pervasive Computing Lab (Embedded) > Electrical Engineering Department (DEE) > Center of Electrical Engineering and Informatics (CEEI) > Federal University of Campina Grande (UFCG) > > Blog: http://genuinepulse.blogspot.com/ > ------------------------------------------------------------------------------ > Enter the BlackBerry Developer Challenge > This is your chance to win up to $100,000 in prizes! For a limited time, > vendors submitting new applications to BlackBerry App World(TM) will have > the opportunity to enter the BlackBerry Developer Challenge. See full prize > details at: http://p.sf.net/sfu/Challenge > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
