On Sat, Nov 7, 2009 at 11:44 AM, Mathieu Taillefumier
<mathieu.taillefum...@free.fr> wrote:
> Hello,
>
> herewith a patch for ecore that implement the eina_log inside ecore for
> logging messages. I have been using the patch for some time now and nothing
> happened since then. I double check the patch and everything should be
> compiling without error, but since nobody is perfect I can not warranty the
> win modules will compile (normally they should).
>
> I think all main libraries are converted already. I still have to work on
> edje, emotion and e itself.
sorry taking so long to reply, but here it goes:
first of all, ecore-config is deprecated... so no need to really
convert it, but it doesn't hurt much either.
+ ERR("ipc.prop.set(%s->%s,\"%s\") => %d\n", theme ? theme->identifier : "",
+ key, val, ret);
good, you're using ERR() and should have no problems with win32... but
the trailing \n is still there and eina log adds it as well :-/
+# define D(fmt,args...) do { if(DEBUG>=0) DBG(fmt,## args); } while(0);
+# define E(lvl,args...) do { if(DEBUG>=(lvl)) ERR(## args); } while(0)
these are bit useless, no need to do these in app/lib since it's done in eina.
+ WRN("you are using ecore_config structures. These are very young");
+ WRN(" and not complete - you have been warned");
similarly to previous where you left \n, this one was expected to be
printed as one single phrase using previous debug, but now are 2 lines
with prefix repeated... you better make it a single WRN()
Last, make log domain variable -1 after unregister it:
eina_log_domain_unregister(_ecore_imf_log_dom);
+ _ecore_imf_log_dom = -1;
so we catch people calling module functions after it was shutdown.
Eina log should not crash if you don't, but in some cases another
domain may be registered with the same id and then you'll get wrong
prefix and all.
--
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--------------------------------------
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
