> On Sat, Nov 7, 2009 at 11:44 AM, Mathieu Taillefumier
> <mathieu.taillefum...@free.fr> wrote:
>
>> Hello,
>>
>> herewith a patch for ecore that implement the eina_log inside ecore for
>> logging messages. I have been using the patch for some time now and nothing
>> happened since then. I double check the patch and everything should be
>> compiling without error, but since nobody is perfect I can not warranty the
>> win modules will compile (normally they should).
>>
>> I think all main libraries are converted already. I still have to work on
>> edje, emotion and e itself.
>>
> sorry taking so long to reply, but here it goes:
>
> first of all, ecore-config is deprecated... so no need to really
> convert it, but it doesn't hurt much either.
>
> + ERR("ipc.prop.set(%s->%s,\"%s\") => %d\n", theme ? theme->identifier :
> "",
> + key, val, ret);
>
> good, you're using ERR() and should have no problems with win32... but
> the trailing \n is still there and eina log adds it as well :-/
>
Learn it from converting evas to eina_log :-).
> +# define D(fmt,args...) do { if(DEBUG>=0) DBG(fmt,## args); } while(0);
> +# define E(lvl,args...) do { if(DEBUG>=(lvl)) ERR(## args); } while(0)
>
> these are bit useless, no need to do these in app/lib since it's done in eina.
>
I cleaned up my previous patch and corrected some errors I did not spot
the first time. the list of changes is the following :
- the messages have been suppressed when necessary.
- the ecore_config file was changed following the suggestions of Gustavo
:-).
- finally add some additional line _ecore_module_name_log_dom = -1;
after unregistering a log domain. I applied this to all the modules
(including the windows one)
Best
Mathieu
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
