On Mon, Dec 21, 2009 at 7:07 PM, Gustavo Sverzut Barbieri <barbi...@profusion.mobi> wrote: > On Mon, Dec 21, 2009 at 4:02 PM, Cedric BAIL <cedric.b...@free.fr> wrote: >> On Mon, Dec 21, 2009 at 6:42 PM, Gustavo Sverzut Barbieri >> <barbi...@profusion.mobi> wrote: >>> On Mon, Dec 21, 2009 at 3:32 PM, Enlightenment SVN >>> <no-re...@enlightenment.org> wrote: >>>> Log: >>>> * ecore: Use eina_log. >>>> >>>> Patch from Mathieu Taillefumier. >>>> >>>> +EAPI int _ecore_log_dom = -1; >>> >>> it's not EAPI, at least it should not be... any reason to do so? If >>> it should be visible inside the libecore.so (as I think) it should not >>> be visible outside it with EAPI. >> >> Problem is that ecore_private.h is used in all ecore directory. So >> it's not that easy to guess. > > Hum... so we need to create individual _private.h for each module as > well, and add the logging there. > > At least each module should have it's own logging.
Yep, but in fact ecore_private.h should not be used outside of it's directory at all. So some cleanup are required here. -- Cedric BAIL ------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
