On Sun, 28 Feb 2010 22:20:53 +0000 Rui Miguel Silva Seabra <r...@1407.org> said:
> Em 28-02-2010 22:18, Vincent Torri escreveu: > > > > > > On Sun, 28 Feb 2010, Rui Miguel Silva Seabra wrote: > > > >> Em 28-02-2010 22:10, Vincent Torri escreveu: > >>> > >>> > >>> On Sun, 28 Feb 2010, Rui Miguel Silva Seabra wrote: > >>> > >>>> Hello, > >>>> > >>>> The attached patch would seem to add http basic auth to ecore_con_url > >>>> > >>>> I'm still testing it, but I'd like to know the opinion of others on its > >>>> addition. I'm still a bit too shy to commit real code in core EFL > >>>> libraries :) > >>> > >>> * don't use asprintf : not portable > >> > >> Will look into other way to do that part. > > > > buffer + snprintf > > I am allocating memory as I don't like to waste space on buffers :) they are temporary (buffers) whne on the stack - func returns - they go away. nothing gets fragmented either. unless you put a few hundred kb on the stack - it doesnt matter. you're not doing micro-cotrollers. it's perfectly fine to do char buf[4096]; snprintf(buf, sizeof(buf), "a:%s", str); thats just fine - as long as you expect your styring to norrmally never come anywhere near the buffer size limit - if it might - you may need ot check. it may be that some other limit exists anyway (a lot of this stuff uses PATH_MAX as the os imposes a limit to a path anyway - so if the buffer isnt big enough - doesnt matter - next level down till spit the dummy anyway). so choose a reasonable size thats "bigger than you may ever reasonably need" and use that. > >>> * follow the coding style > >> > >> I thought I did, what did I do wrong? > > > > if () > > { > > int i; // 3 spaces after to column of the opening bracket > > } > > > > and use tabs for multiples of 8 spaces. Unfortunately, that horror is > > propagated through all the EFL because of the editor that raster uses. > > The guys who wrote this editor should be tortured. > > Oh no, don't drag me into text editor wars ;) > > Rui > > ------------------------------------------------------------------------------ > Download Intel® Parallel Studio Eval > Try the new software tools for yourself. Speed compiling, find bugs > proactively, and fine-tune applications for parallel performance. > See why Intel Parallel Studio got high marks during beta. > http://p.sf.net/sfu/intel-sw-dev > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel