On Mon, 18 Oct 2010 11:15:59 -0700
"Enlightenment SVN" <no-re...@enlightenment.org> wrote:

> Log:
>   Fixes for clang warnings
>   
> Author:       bdilly
> Date:         2010-10-18 11:15:59 -0700 (Mon, 18 Oct 2010)
> New Revision: 53576
> 
> Modified:
>   trunk/TMP/st/elementary/src/lib/elm_cnp_helper.c
> trunk/TMP/st/elementary/src/lib/elm_menu.c 
> 
> Modified: trunk/TMP/st/elementary/src/lib/elm_cnp_helper.c
> ===================================================================
> --- trunk/TMP/st/elementary/src/lib/elm_cnp_helper.c
> 2010-10-18 18:05:22 UTC (rev 53575) +++
> trunk/TMP/st/elementary/src/lib/elm_cnp_helper.c      2010-10-18
> 18:15:59 UTC (rev 53576) @@ -1160,7 +1160,7 @@ int i;
>  
>     /* Skip it */
> -   if (enter->num_types == 0 || enter->types == NULL) return true;
> +   if (!enter || !enter->num_types || !enter->types) return
> EINA_TRUE; 

The function argument should be annotated here, it's an appropriate
place for a not null as it's a callback.  If ecore is sending NULL to
it's callbacks, all bets are off.  

<insert standard automated tools disclaimer regarding symptom and
problem>

        Regards,
        nash

------------------------------------------------------------------------------
Download new Adobe(R) Flash(R) Builder(TM) 4
The new Adobe(R) Flex(R) 4 and Flash(R) Builder(TM) 4 (formerly 
Flex(R) Builder(TM)) enable the development of rich applications that run
across multiple browsers and platforms. Download your free trials today!
http://p.sf.net/sfu/adobe-dev2dev
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to