On Tue, Oct 19, 2010 at 8:58 AM, Gustavo Sverzut Barbieri
<barbi...@profusion.mobi> wrote:
>> --- trunk/TMP/st/elementary/src/lib/elm_diskpicker.c 2010-10-19 05:58:26
>> UTC (rev 53590)
>> +++ trunk/TMP/st/elementary/src/lib/elm_diskpicker.c 2010-10-19 10:48:11
>> UTC (rev 53591)
>> @@ -388,13 +388,15 @@
>>
>> EINA_LIST_FOREACH(list, l, it)
>> {
>> - int len = strlen(it->label);
>> Evas_Coord x, w;
>> + int len;
>> evas_object_geometry_get(it->base.view, &x, NULL, &w, NULL);
>> /* item not visible */
>> if (x + w <= ox || x >= ox + ow)
>> continue;
>>
>> + len = strlen(it->label);
>
> likely what's in an internal item should be stringshared, then
> eina_stringshare_strlen() is O(1) :-)
Do you want an automatic conversion from strlen() to
eina_stringshare_strlen() when the parameter is indeed stringshared?
It's pretty easy for coccinelle
Lucas De Marchi
------------------------------------------------------------------------------
Download new Adobe(R) Flash(R) Builder(TM) 4
The new Adobe(R) Flex(R) 4 and Flash(R) Builder(TM) 4 (formerly
Flex(R) Builder(TM)) enable the development of rich applications that run
across multiple browsers and platforms. Download your free trials today!
http://p.sf.net/sfu/adobe-dev2dev
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
