Dear Daniel,
Generally I'd agree with you, but I think this change should not happen
now. These kind of changes should better occur in times when there are
less changes, because style changes make the diff programs go nuts.
Currently a colleague of mine (and many others) have a lot of local
changes to elementary which are either waiting to be applied upstream
after the code freeze on edje/evas ends (because the elementary changes
depend on them), or just because the features he is writing are not yet
complete.
So I suggest we do this in some later time (X days/weeks after the rest
of the EFL code freeze ends) in order to save a lot of extra merge work.
--
Tom.
On Mon, 2010-12-13 at 01:21 +0900, Daniel Juyung Seo wrote:
> Anybody can review this?
>
> Even this includes many changes of lines,
> this is very simple.
> Then I would go for the next patch.
>
> Or reject this and give me a reason.
> Thanks.
>
> Daniel Juyung Seo.
>
> On Fri, Dec 10, 2010 at 2:30 AM, Daniel Juyung Seo <seojuyu...@gmail.com>
> wrote:
> > Hello,
> >
> > I found that there are three big unnecessary 'if' statements in
> > els_scroller.c in elementary.
> >
> > ex)
> >
> > static void
> > _smart_event_mouse_down(...)
> > {
> > ...
> > if (_elm_config->thumbscroll_enable)
> > {
> > Many small if statements and this is very LONG.
> > }
> > NOTHING HERE.
> > }
> >
> > I suggest to use 'return' if _elm_config->thumbscroll_enable equals to
> > EINA_FALSE.
> > This increases readability of code and reduces unnecessarily cascaded
> > indentation.
> >
> > suggestion)
> >
> > static void
> > _smart_event_mouse_down(...)
> > {
> > ...
> > if (!_elm_config->thumbscroll_enable) return;
> >
> > "many small if statements"
> > }
> >
> > This pattern could be applied to _smart_event_mouse_move and
> > _smart_event_mouse_up as well.
> > Please give me some comments on this.
> > Thanks.
> >
> > Daniel Juyung Seo.
> >
>
> ------------------------------------------------------------------------------
> Oracle to DB2 Conversion Guide: Learn learn about native support for PL/SQL,
> new data types, scalar functions, improved concurrency, built-in packages,
> OCI, SQL*Plus, data movement tools, best practices and more.
> http://p.sf.net/sfu/oracle-sfdev2dev
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
------------------------------------------------------------------------------
Oracle to DB2 Conversion Guide: Learn learn about native support for PL/SQL,
new data types, scalar functions, improved concurrency, built-in packages,
OCI, SQL*Plus, data movement tools, best practices and more.
http://p.sf.net/sfu/oracle-sfdev2dev
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
