On Thu, 16 Dec 2010 15:37:32 +0900 Hyoyoung Chang <hyoyoung.ch...@samsung.com>
said:

ok. i've put this in svn - though looking here.. the code in general needs some
real overview. the png handler is used already for jpg and png - and now bmp
too... why was it not just named a generic img handler... and then the
extension checker should probably use an array/table of extensions.. and jpg
comes in more than jpg extension .. jpg, jpeg, jfif, jfi, jpe... :) i'll fix
this later. first this commit in as such it doesnt make the code worse. :)
(though you also fixed a type you didn't mention - the ut-8 vs utf-8)..

> Dear Brett Nash, and Elementary developers.
> 
> It's a elm_cnp_helper patch.
> 
> main changes are
>     1. check string length when retrieving filename
>     2. adding bmp filetype and ignoring filetype case
> 
> Thank you.
> 
> -------------------------------------------
> Hyoyoung CHANG
> Engineer 
> 
> SAMSUNG ELECTRONICS, Co., Ltd. 
> E-mail: hyoyoung.ch...@samsung.com 
> -------------------------------------------


-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler)    ras...@rasterman.com


------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to