On Mon, 20 Dec 2010 16:30:33 -0500 Mike Blumenkrantz <m...@zentific.com> said:
> On Sun, 19 Dec 2010 15:19:31 -0800 > Michael Jennings <m...@kainx.org> wrote: > > > On Sunday, 19 December 2010, at 23:47:43 (+0100), > > Joerg Sonnenberger wrote: > > > > > > The spec files use: > > > > > > > > svnversion | sed 's/[^0-9].*$//' || echo 0000 > > > > > > > > which is portable. > > > > > > One important differences is that it picks up M if you have any local > > > changes. > > > > Check again. :) > > > > Michael > > > Unless I get some negative replies, I'm going to go through and make this > change across trunk/ i'd say no - why change what works just to make the shell script shorter by a bit? michael already made a point - you will get the M. by changing this you: 1. risk breaking things where grep isn't a full gnu grep 2. change the numbers to include things that were filtered out before for what gain? some "shell script purity"? no. i say no. it works. it's been tested widely by now. don't break it. there is no gain in changing it. -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Lotusphere 2011 Register now for Lotusphere 2011 and learn how to connect the dots, take your collaborative environment to the next level, and enter the era of Social Business. http://p.sf.net/sfu/lotusphere-d2d _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
