Raster, can you review this? Barbieri doesn't look like having enough time to check this patch.
Thanks. Daniel Juyung Seo (SeoZ) On Mon, Dec 20, 2010 at 12:24 PM, Myungjae Lee <mjae....@samsung.com> wrote: > Hi, Gustavo. Thank you for your opinion. > > First, I'd like to ask one thing. Why does elm_box use its own layout > function instead of one of the evas_object_box layout functions? Because I > don't know the history fully, can you or anybody here explain it to me > briefly? > > When I implemented some box related features such as extended mode(similar to > flow) and request size there were a lot of differences in layout functions > between elm box and evas box, so it was not easy to follow the way evas box > did and merge it to elm box. That's why I made ex mode to elm box. (I think > the name can be changed to 'flow' not to make confusion. But, currently elm > box does not use the same name with evas box, plz refer to these APIs.. > 'elm_box_pack_start / evas_object_box_prepend', 'elm_box_pack_end / > evas_object_box_append' and 'elm_box_unpack(_all) / > evas_object_box_remove(_all)') > > And there are differences between evas box flow and elementary box extended > mode like below. > 1. In extended box, it should be able to allocate the maximum available size > to some items. The weight-x is used for this in horizontal extended mode box. > 2. In horizontal extended(flow) mode, if weight-y is 1(EXPAND) and align-y is > -1(FILL), the item should be expanded vertically as much as possible. But > evas box does not do like this. > > So I attached the new sample source code for comparing elm box extended mode > and evas box flow mode. > Please review this sample code along with the previous patch files. > > Thank you. > > > > -----Original Message----- > From: Gustavo Sverzut Barbieri [mailto:barbi...@profusion.mobi] > Sent: Thursday, December 16, 2010 9:34 PM > To: Myungjae Lee > Cc: enlightenment-devel@lists.sourceforge.net > Subject: Re: [E-devel] [PATCH] elm box: extended mode added > > On Thu, Dec 16, 2010 at 5:55 AM, Myungjae Lee <mjae....@samsung.com> wrote: >> Hello, all. >> >> This is a patch for extended mode box. >> >> When we insert objects into the horizontal mode box, the width of the box >> increases according to the sum of items' min size without any limitation. In >> a special case, such as typing recipients in the iphone email application, >> objects in the box needs to be aligned automatically within the box width. >> When a box is resized, all items are positioned as much as acceptable and >> the remained items are put into the next line(under the max height of the >> first aligned objects). This will be repeated until all items are displayed. >> >> The extended mode box is an added feature and it doesn't break normal box >> behavior at all. >> >> I think it's not easy to explain whole features in extended mode box, so I >> attached the test application for elementary_test. >> Please test 'Box Extended' in elementary_test first and review this source >> code next. >> >> If any issues are there or this doesn't meet any other requirement, please >> let me know it. > > Hi, > > I can't look the code anytime soon, but how this compares to the > existing "flow" modes? From your description it looks exactly like > them, with the exception your just work with elementary and not with > pure-evas. > > -- > Gustavo Sverzut Barbieri > http://profusion.mobi embedded systems > -------------------------------------- > MSN: barbi...@gmail.com > Skype: gsbarbieri > Mobile: +55 (19) 9225-2202 > > ------------------------------------------------------------------------------ > Lotusphere 2011 > Register now for Lotusphere 2011 and learn how > to connect the dots, take your collaborative environment > to the next level, and enter the era of Social Business. > http://p.sf.net/sfu/lotusphere-d2d > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > ------------------------------------------------------------------------------ Lotusphere 2011 Register now for Lotusphere 2011 and learn how to connect the dots, take your collaborative environment to the next level, and enter the era of Social Business. http://p.sf.net/sfu/lotusphere-d2d _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
