On Thu, 16 Dec 2010 16:55:14 +0900 Myungjae Lee <mjae....@samsung.com> said:
ok. review time: 1. Elmentary.h.in.patch.txt contains patches for scroller propagate events api changes too! bad1 check your patches to make sure they include only what you want to include :) 2. testing. when u resize the window with the test down.. it doesnt have a minimum horizontal size! :) i can make it smaller than the largest buttons! bug! box min horizontal size in this case should be the min width of the "widest" member. 3. extended is probably the wrong word. flow or wrap are better. i'd go wrap as basically thats what it does.. like text its wrapping items in a box. 4. you implemented "extended" only for horizontal... what about vertical box layout? why not? it's a logical extension to the idea and simply a matter of the same logic being in another if case with coordinates reversed. 5. minor spacing/formatting booboos in there too. like if(x) instead of if (x) and missing bracketing of expressions in if's 6. missing any form of alignment - what if we want to flow and align to the right, not the left? (yes - you'd need this for right-to-left locales - arabic etc.). and... 7. evas box vs elm box. what gustavo says is correct. elm box comes from e box which outdates evas box by a long margin. but it does use and function with size hints. i think there are some subtle minor difference in layout code/policy. it needs some going over and review to make sure they merge - as such elm_box is very little more than evas_box + custom layout func - that you modified. i don't see a big problem with this - as it's already the case. but at some point these need to merge to avoid there forever being 2. but this patch is not the time or place to do that - as such elm box could do with the ability to turn on "wrap" but how its implemented below is a matter of more intricate merge work. so - can you -re-submit the patch with the above fixes.. but don't worry about #7 for now. it's going to have to wait until after 1.0 > Hello, all. > > This is a patch for extended mode box. > > When we insert objects into the horizontal mode box, the width of the box > increases according to the sum of items' min size without any limitation. In > a special case, such as typing recipients in the iphone email application, > objects in the box needs to be aligned automatically within the box width. > When a box is resized, all items are positioned as much as acceptable and > the remained items are put into the next line(under the max height of the > first aligned objects). This will be repeated until all items are displayed. > > The extended mode box is an added feature and it doesn't break normal box > behavior at all. > > I think it's not easy to explain whole features in extended mode box, so I > attached the test application for elementary_test. > Please test 'Box Extended' in elementary_test first and review this source > code next. > > If any issues are there or this doesn't meet any other requirement, please > let me know it. > > Thanks. > > > P.S. One more thing, when I sent a patch for scroller I missed adding the > function declaration to the header file. So I included it in this patch. -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Lotusphere 2011 Register now for Lotusphere 2011 and learn how to connect the dots, take your collaborative environment to the next level, and enter the era of Social Business. http://p.sf.net/sfu/lotusphere-d2d _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
