Hello Raster,
Thanks.

I added a small patch for Genlist Group.
I missed one. Thanks Govi!
Can you review this and apply it to upstream?

Thanks.
Daniel Juyung Seo (SeoZ)

-----Original Message-----
From: Carsten Haitzler (The Rasterman) [mailto:ras...@rasterman.com] 
Sent: Thursday, January 06, 2011 2:14 PM
To: Seunggyun Kim
Cc: manti...@samsung.com; enlightenment-devel@lists.sourceforge.net
Subject: Re: [E-devel] [Patch] Group index support

On Thu, 30 Dec 2010 21:31:40 +0900 Seunggyun Kim <sgyun....@samsung.com>
said:

looks ok to me. in svn! :)

> Hello,
> 
> I added group index feature.
> This feature support to show item indicates group index.
> I attached capture images showing group index.
> As you can see attached png images, Group index item includes same group
> items.
> 
> The group index is shown until every items that have same group index are
> scrolled.
> so group index realize/unrealize is not excuteded in _item_block_position
> function.
> instead of the function, group index is controlled in _pan_calculate
> function.
> 
> "Genlist Group" and "Genlist Group Tree" menu is added in elementary_test.
> you can test group index operations in elementary_test.
> 
> This patch is not support elm_genlist_item_insert_before/after operation
of
> group index.
> We are now considering the operations in group index.,
> 
> This patch assumes that the previous 2 patches are already applied to
> upstream.
> '[E-devel] [Patch] Tree support for elm_genlist_item_prepend() API.'
> '[E-devel] [Patch] Tree support for elm_genlist_item_insert_before/after()
> APIs',
> So this patch does not include the changes of the previous patch.
> 
> I separated this patch.
> 
> - 004.elm_genlist.c.patch.txt
>     Patch for src/lib/elm_genlist.c
> - 005.test_genlist.c.patch.txt
>     Patch for src/bin/test_genlist.c 
> - 006.genlist.patch.txt
>     Patch for data/theme/default.edc
> 
> And you have to add attached group_index.png file into 'data/themes'
> 'group_index.png' file is group index background image. 
> 
> 
> Daniel Juyung Seo help make test code and refactoring group index code.
> 
> Please review it and let me know if there is any problem in this patch.
> 
> Thanks.
> Seunggyun Kim
> 


-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler)    ras...@rasterman.com


----------------------------------------------------------------------------
--
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment,
and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Index: src/lib/elm_genlist.c
===================================================================
--- src/lib/elm_genlist.c       (revision 55925)
+++ src/lib/elm_genlist.c       (working copy)
@@ -3769,7 +3769,7 @@ elm_genlist_item_show(Elm_Genlist_Item *it)
       gith = it->group_item->h;
    elm_smart_scroller_child_region_show(it->wd->scr,
                                         it->x + it->block->x,
-                                        it->y + it->block->y,
+                                        it->y + it->block->y - gith,
                                         it->block->w, it->h);
 }
 
------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to