On Thu, 06 Jan 2011 23:57:53 -0200 Raphael Kubo da Costa <k...@profusion.mobi> said:
> At Fri, 7 Jan 2011 10:25:05 +0900, > Carsten Haitzler (The Rasterman) wrote: > > i know. i only cared about fixing up the api for 1.0 - internals can always > > be changed. i just took the fastest path to getting api set up. > > > > one thing i was hoping you'd comment on... "we have get and post... where's > > put?" :) > > I thought you were only caring about fixing up the api for 1.0 etc etc ;D bingo. as long as it functions "as intended" (and deprecated fn just functions as it used to until it's killed), i dont care too much. it's a relatively insignificant and isolated bit of code - can be fixed up any time with no affect on api/abi :) > > > Anything agains having an enum? Plus, if both AUTO and POST have the > > > same effect, why not have only POST and adapt ecore_con_url_send > > > accordingly? > > > > because i wasnt sure i'd get it right for both - and as such auto will be > > killed eventually as its deprecated. :) > > Fine then. Is the 'stuff that should be killed after 1.0 or 1.x' being > tracked anywhere? I fear this might just sit there indefinitely until > someone notices. nup. but as such the only thing hat passes in auto is the deprecated send api - so i see it as an obvious link :) > > > It should be noted somewhere that passing NULL to data and 0 to length > > > performs a bodyless POST. > > > > if its an explicit post call.. isnt that obvious? :) no data - no body :) > > One might think, for example, that just passing NULL to data (or 0 to > length) is enough, just like it happened in one of your previous > commits to this part. well if u pass null - sending length != 0 is nonsensical. sending a data ptr but with length 0 also is nonsensical. :) so it goes hand-in-hand i'd say. if u have body data - it is more than 0 bytes in size.. and u have a pointer to it. otherwise it's NULL and well size is obviously 0. now that we can actually define a get vs a post we dont need to piggyback data + size to guess what to do. :) -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Gaining the trust of online customers is vital for the success of any company that requires sensitive data to be transmitted over the Web. Learn how to best implement a security strategy that keeps consumers' information secure and instills the confidence they need to proceed with transactions. http://p.sf.net/sfu/oracle-sfdevnl _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
