Hehe, that's my log! I need the log *before* I commit! (j/k). Thanks, Tom.
On Wed, 2011-02-02 at 17:58 +0900, Daniel Juyung Seo wrote: > Thanks Tom. > I appreciate you. > I'm gonna follow the rule then :) > > >> Elementary genlist: Fix places that weren't using > >> ELM_GENLIST_ITEM_FROM_INLIST. Patch by Daniel Juyung Seo (SeoZ). > > Thanks. > Daniel Juyung Seo (SeoZ) > > > -----Original Message----- > From: Tom Hacohen [mailto:tom.haco...@partner.samsung.com] > Sent: Wednesday, February 02, 2011 5:37 PM > To: Daniel Juyung Seo > Cc: enlightenment-devel@lists.sourceforge.net > Subject: Re: [E-devel] [Patch] Genlist patch for wrong casting. > > In, thanks. One comment though: please in the next time (and this > applies to everyone) add a summary that suites an svn log :) > > You gave an excellent summary that made me understand exactly what the > patch is about and that's great, but I still need to write the svn log > myself and although that's not a lot of time by itself, things add up. > Please also spread the word about it :) > > Just to make sure I'm clear: the summary you gave is awesome and that's > *also* needed to be included, I'm just saying people should also include > an svn suitable summary. > > Thanks, > Tom. > > On Wed, 2011-02-02 at 16:35 +0900, Daniel Juyung Seo wrote: > > Hello, > > I made a patch to fix wrong casting bug. > > > > While using Eina_Inlist, do not use force-casting for EINA_INLIST_GET. > > Use ELM_XXX_ITEM_FROM_INLIST macro instead. > > > > Barbieri adopted this concept about 3~4 months ago. > > So we can place EINA_INLIST macro to any place we want in a custom > > structure. > > It used to be placed at the first line of a custom structure. > > > > Ms. Sohyun noticed that there are some mis-usages in genlist before. > > I checked gengrid and toolbar as well. They are clean :) > > > > Please review this and apply this to upstream. > > Daniel Juyung Seo (SeoZ) > > > > ------------------------------------------------------------------------------ > > Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! > > Finally, a world-class log management solution at an even better price-free! > > Download using promo code Free_Logger_4_Dev2Dev. Offer expires > > February 28th, so secure your free ArcSight Logger TODAY! > > http://p.sf.net/sfu/arcsight-sfd2d > > _______________________________________________ enlightenment-devel mailing > > list enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > ------------------------------------------------------------------------------ Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
