well sure the changelog :P
I'll make those changes soon
2011/2/10 Vincent Torri <[email protected]>
> Hey,
>
>
> On Thu, 10 Feb 2011, michael bouchaud wrote:
>
> Hi, everybody I have wrote an evas_image loader for raw image type. I use
>> libraw-lite to do this jobs, who is licensed under lgpl
>> This is not perfect, so please review this code. Any comments are welcome
>> !
>>
>
> some things:
>
> 1) ChangeLog
> 2) remove all the Evil stuff, I'll test it later on Windows
> 3) the check in EVAS_CHECK_LOADER_DEP_RAW is wrong, use pkg-config (see
> EVAS_CHECK_LOADER_DEP_EET for example)
> 4) some formatting stuff :
>
> if(
> --> if (
>
> + if (image->bits == 16 && htons(0x55aa) != 0x55aa)
>
> --> if ((image->bits == 16 && htons(0x55aa)) != 0x55aa)
>
> Also the double loop :
>
> + for (y = 0; y < image->height; y++)
> + {
> + for (x = 0; x < image->width; x++)
> + {
> + *dataptr = ARGB_JOIN(0xff, bufptr[0], bufptr[1],
> bufptr[2]);
> + dataptr++;
> + bufptr += 3;
> + }
> + }
>
> is useless, only one is sufficient (loop over 0 to height*width-1)
>
> there are other m4 stuff i would like to change
>
> that's all for now, after a small review
>
> Vincent
>
>
>
> ps: I have quickly packaged libraw-lite with autotools, so I provide you
>> this package to test it quickly
>>
>> --
>> Michaël Bouchaud
>>
>
--
Michaël Bouchaud
--
Michaël Bouchaud
------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
