On Fri, 11 Feb 2011, michael bouchaud wrote:
> 2011/2/11 Vincent Torri <vto...@univ-evry.fr> > > >> >> On Fri, 11 Feb 2011, michael bouchaud wrote: >> >> On Thu, 10 Feb 2011, michael bouchaud wrote: >>>>> >>>>> Hi, everybody I have wrote an evas_image loader for raw image type. I >>>>> use >>>>> >>>>>> libraw-lite to do this jobs, who is licensed under lgpl >>>>>> This is not perfect, so please review this code. Any comments are >>>>>> welcome >>>>>> ! >>>>>> >>>>>> >>>>> some things: >>>>> >>>>> 1) ChangeLog >>>>> 2) remove all the Evil stuff, I'll test it later on Windows >>>>> 3) the check in EVAS_CHECK_LOADER_DEP_RAW is wrong, use pkg-config (see >>>>> EVAS_CHECK_LOADER_DEP_EET for example) >>>>> >>>> >>>> This is a new version of this patch. I don't change the m4 macro because >>> libraw_lite aren't correctly packaged for now. So pkg-config can't detect >>> them. I added an entry in changelog and change the double loop. I have >>> also >>> changed the header loading code. >>> Any comments still are welcome ! >>> >> >> he problem is that if someone installs libraw in another dir than /usr, the >> detection will fail. >> >> There is a .pc file that is provided with libraw (actually, there are 2 >> .pc, one for thread safe libn another for non thread safe lib). You should >> (must) use one of them >> >> Vincent >> > > yeah 2 pc files are given with libraw (under gpl) but not with libraw-lite > (under lgpl). Sure the test of this macro is definitely bad. But I don't > know how to detect this without pc files. go here > http://www.libraw.org/libraw-lite to download libraw-lite not libraw haaa, i certainly downloaded libraw. Ok, then look at the tiff m4 macro (note that it has 3 AC_CHECK_LIB because the name of the lib is not always the same and because it can have some dependencies. You should just use one AC_CHECK_LIB Vincent ------------------------------------------------------------------------------ The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
