On Tue, 08 Feb 2011 09:28:32 +0000 (GMT) ChunEon Park <chuneon.p...@samsung.com> said:
> > Hi Tom, sorry for replying lately. > > > The reason, a ctxpopup is openning really far from where user click, is... > > currently it is intended to be affected by finger size. > > Yes. I realized just before that fact - it's not good concept as the > desktop widget > > since the original concept of ctxpopup is for the touch screen environment. > > (It means when user touches any point on the screen then ctxpopup will be > showed up far from the user's finger.) > > > I need to think how to meet both two cases. > > (I think ctxpopup needs to provide an another API for that finger size > > or could you please adivse for it?) > there is a good way to make this be done the right way. the "point" for the arrow is ALWAYS put were the finger/mouse presses, BUT you also swallow an invisible rectangle into a swallow. you put this swallow around where the arrow would go - creating the ability for this swallow's minimum size to PUSH the rest of teh ctxpopup away from the swallow - the swallow min size is set to finger size. index widget uses this trick kind-of to have a finger-sized "hit region" on the side. you do the same, but just for spacing. so on desktop it will pop up right near the mouse. on a touchscreen with fat fingers.. it will pop up a long way away :) everyone is happy - and the DESIGNER can either just add blank space OR he can connect the down/click/press point with the ctxpopup box - up to him if he makes the arrow stretch or be bigger or just move and leave space. :) eg: Press point +-------*--------+<- ctxpopup/edje object size as a whole | +---+ | | | | <- swallow (on desktop it'll be like 1 or 5 pixels in size so | +---+ no gap or small gap, on finger screens... big gap! | ------^------- | || Popup Content|| | -------------- | +----------------+ > Arrow issue.. I really don't know what arrow issue you mean... > > Could you explain again? > > > and the patch 003... > > It's my fault. > > Maybe I shouldn't use the elm_object_scroll_freeze/hold APIs. > > It affects parent's scroller so it causes problems. > > (I really wonder why elm_object_scroller_freeze/hold affect their own > parent scroller?) > > Maybe, ctxpopup should provide another scroller enable/disable APIs > additionally. > > > I need to check it again. Please don't mind the 003_patch now. > > > And the last one. elm_list ! > > I understood why we reuse the exist widgets and avoid duplicated functions. > > I will do that if it can be done. > > > I thought elm_list can be impossible to meet the ctxpopup fucntionality. > > Before my patch, elm_ctxpopup has a problem about it's sizing. > > and the first motive widget of ctxpopup is elm_menu (it does not > use elm_list.). > > > Anyway, The problem is, > > Ctxpopup should know it's list size to position. > > Sametime, list should know it's items sizes to determine the ctxpopup's > size. > > Once I can know the list's total item size, then i can determine ctxpopup > size and position > > or readjust the list size additionally. > > > I concerned about that I dont' know the size of list when determine the > position. > > > Currently ctxpopup calculates it's box size first then finds available > space from the it's position. > > If ctxpopup uses the list, then it dont' know the size of the total items. > maybe... > > > Anyway, Yes, this time I need to check the possibility of using of > elm_list again. > > (I do it first when I am free, then try it upstreamed if it can be done ) > > > I hope you consider that elm_list can cover the above case > > > Anyway, I appreciate you for concerning this widget. :) > > > From Hermet. > > > ------- Original Message ------- > > Sender : Tom Hacohen<tom.haco...@partner.samsung.com> Engineer/STRI-SLP RTL > Language supporting/삼성전자 > > Date : 2011-02-04 00:04 (GMT+09:00) > > Title : Re: [E-devel] ctxpopup is completely broken > > > Another comment: you still haven't replied regarding the issue with the > arrow and the ctxpopup opening really far from where you click. > Thanks, > Tom. > On Thu, 2011-02-03 at 08:14 +0000, Tom Hacohen wrote: > > Hey Hermet, > > > > My comments are inlined. > > > > On Wed, 2011-02-02 at 12:28 +0000, ChunEon Park wrote: > > > > > > 1. If it looks ugly cause of the gray box for the disabled item, > > > > > > I will send a patch to back the design. I didn't think it's ugly and > > > would not be matter. > > > > Thanks :P > > > > > > > > > > > > 2. why it removed the arrow at the angle? > > > > > > Original ctxpopup did not support the arrow at the angle. if it > > > supported the concept, > > > > > > then the users of ctxpopup would have problems. I tried > > > do prevent the problem at that time first. > > > > > > Now, we can consider about supporting arrow at the angle. > > > > I don't really care just was interested because this is part of the > > things lost in your change. > > > > > > > > > > > > 3. why it ditched the elm_list? > > > > > > => here is the email when i sent it for ditching the elm_list. > > > > > > > > > > > > ==================================================== > > > > > > Hi, this is Hermet. > > > > > > Here code is for the ctxpopup. > > > > > > Since the functionalities of ctxpopup are somewhat different, > > > I'm trying to overwrite the ctxpopup code entirely first. > > > > > > The main reason is, > > > Original ctxpopup could determine it's size and position by itself. > > > Of course, upstreamed version supports this. But it can not be reduced > > > it's > > > size > > > And it supposes the arrow position to center of box edje. > > > > > > Basically, > > > This version calculates it's box size first then find available space > > > from > > > the it's position. > > > The origin position of the box is not expected, it finds the available > > > positions. > > > But if there is not enough space to be shown, then it finds a best > > > direction > > > to be shown again. > > > In this case, it reduces it's size also as to be shown entirely. > > > Since the ctxpopup supports scroller, the reduced box could show the > > > all > > > items also. > > > (The point is ctxpopup should know the size of total items...) > > > > > > I'm not sure the upstreamed version could cover the above scenario, > > > If then, I need to modify it first. > > > > > > Or not, please review this code. It should have a review definitely. > > > > > > Thanks. > > > > This sounds useful enough to be added to elm_list/genlist and also > > fairly simple to add. (i.e get wanted/max size according to child). > > Doing it in elm_list/genlist would make everything a lot simpler. > > This reduces code duplication (implementing a list in two different > > places) which in turn makes bug fixing a lot easier (bug spotted in list > > will affect everything), makes the code smaller (thus less footprint in > > memory/cache) and simpler to understand. > > > > I honestly think those changes should be reverted, but maybe I just > > didn't understand you correctly. > > > > -- > > Tom. > > > > > > > > ---------------------------------------------------------------------------- > -- > > Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! > > Finally, a world-class log management solution at an even better > price-free! > > Download using promo code Free_Logger_4_Dev2Dev. Offer expires > > February 28th, so secure your free ArcSight Logger TODAY! > > http://p.sf.net/sfu/arcsight-sfd2d > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > [cid:Z5JE7EUABGFC@namo.co.kr] > > [SeenTimeChecker? > do=bdef14cc591032d5e1c4566816b7cea4ec24f10cf30514bf6b754d17 > d001ca18ba777c355c197185c465c2cf80a2b7ef9aba4bb3b2b5ca43ddd7e184e0604d958075 > b6b33f32d245b7f8aafe245478a5f1d21d5ebee74427cf878f9a26ce15a0] -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel