On Thu, 10 Feb 2011 17:38:21 +0100 (CET) mathieu.taillefum...@free.fr said:
> > > > this is honsetly a minor enough point on the list - that its a close tie. i > > prefer if ((x)&& (y == 3)) myself. i like to clearly group the logic > > entities as its clear then just what you meant in the code. > > > Agreed. > > Dawn, next time, I will make no comments on minor formatting details and just > correct them whatever I think about coding style. But at least I have a clear > answer which I appreciate. > > coming back to the patch. Did someone else test it with nouveau and ati > drivers although I can not do much if backlight is not implemented in the > driver. The simple test program I send should be enough to check if it works > correctly or not on these hardwares. We may need some additional error > messages to indicate what's wrong instead of ERR("Backlight support not > implemented") or anything of the same style. can't help there. nvidia drivers here and none of that is supported in mine (well most of my devices are nvidia - one intel device and a radeon device too that i dont touch much, the intel one does work). -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel