On Mon, 21 Feb 2011 10:27:25 +0900 sangho park <gouach...@gmail.com> said:
a bit better... so now time to nitpick; \(^u^)/ <- yay! hash... why? didn't i just say not to use it?: +static Eina_Hash *ua = NULL; ... + if (ua) eina_hash_free(ua); ... + if (!ua) ua= eina_hash_string_small_new(NULL); + if (eina_hash_find(ua, "User-Agent")) eina_hash_add(ua, "User-Agent", wd->user_agent); + else eina_hash_set(ua, "User-Agent", wd->user_agent); > thanks raster.. elm_button is good example for me. > pls review my new patch. > > On Sun, Feb 20, 2011 at 11:01 PM, Carsten Haitzler > <ras...@rasterman.com>wrote: > > > On Fri, 18 Feb 2011 17:06:58 +0900 sangho park <gouach...@gmail.com> said: > > > > man your implementation is strange. why did you add a whole hash table to > > store > > a single string key with a single string value attached to it? why don't > > you > > just do it like all other elm widgets that need strings - like let's say > > elm_button does with the label? > > > > > Dear all, > > > > > > This is a patch for elm_map for setting user-agent. > > > > > > - Add elm_map_user_agent_set > > > - Add elm_map_user_agent_get > > > - modify doxygen > > > > > > elm_map uses OSM(OpenStreetMap), but we can add custom map provider. > > > If custom map provider server filters robot out (currently default > > > user-agent is 'curl'), > > > we need some APIs to set/get user-agent. > > > > > > pls review this patch. > > > > > > Thanks. > > > BR > > > > > > -- > > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
