On Mon, 21 Feb 2011 18:05:33 +0900 sangho park <gouach...@gmail.com> said:
sorry - my mails are often a stream of consciousness thing - whatever is going through my head at the time comes out. oh and forgot.. in svn! thanks! > always thanks for your good comments, but.. > for me... it takes too much time to decipher your mail. :):):) > > 1. moved global value (hash) to widget structure. > 2. fix stringshare bug > 3. fix found | !found bug > > please review new patch. > > On Mon, Feb 21, 2011 at 3:55 PM, Carsten Haitzler <ras...@rasterman.com>wrote: > > > On Mon, 21 Feb 2011 15:14:38 +0900 sangho park <gouach...@gmail.com> said: > > > > oh there it is. hmmm. i missed that. well i don't see a choice other than > > constructing the hash on the fly. but then you need to rebuild it all the > > time. > > ok ok, but tou need to make the hash table part of the map obj - not a > > global. > > you set eh agent on the map obj - but then use a global hash - and when > > freed u > > dont set it to NULL either. ripe for a segv. so move the hash back into the > > per-obj data but keep the agent as its own stringshare field. when you > > replace > > it - also update the hash. mind you your "if found in hash add has entry" > > shoudl be if !found then add, then set to agent string val. > > > > > the hash value is used by ecore_file_download_full. > > > + ecore_file_download_full(source, buf2, _tile_downloaded, NULL, gi, > > > &(gi->job), ua); > > > > > > 7th parameter of the function can be http headers, but elm_map uses only > > > 'User-Agent'. > > > if I don't use hash, what's your recommendation to use > > > ecore_file_download_full? > > > > > > please show me the way~~ :) > > > > > > > > > On Mon, Feb 21, 2011 at 2:47 PM, Carsten Haitzler <ras...@rasterman.com > > >wrote: > > > > > > > On Mon, 21 Feb 2011 10:27:25 +0900 sangho park <gouach...@gmail.com> > > said: > > > > > > > > a bit better... so now time to nitpick; \(^u^)/ <- yay! > > > > > > > > hash... why? didn't i just say not to use it?: > > > > > > > > +static Eina_Hash *ua = NULL; > > > > ... > > > > + if (ua) eina_hash_free(ua); > > > > ... > > > > + if (!ua) ua= eina_hash_string_small_new(NULL); > > > > + if (eina_hash_find(ua, "User-Agent")) eina_hash_add(ua, > > "User-Agent", > > > > wd->user_agent); > > > > + else eina_hash_set(ua, "User-Agent", wd->user_agent); > > > > > > > > > thanks raster.. elm_button is good example for me. > > > > > pls review my new patch. > > > > > > > > > > On Sun, Feb 20, 2011 at 11:01 PM, Carsten Haitzler > > > > > <ras...@rasterman.com>wrote: > > > > > > > > > > > On Fri, 18 Feb 2011 17:06:58 +0900 sangho park < > > gouach...@gmail.com> > > > > said: > > > > > > > > > > > > man your implementation is strange. why did you add a whole hash > > table > > > > to > > > > > > store > > > > > > a single string key with a single string value attached to it? why > > > > don't > > > > > > you > > > > > > just do it like all other elm widgets that need strings - like > > let's > > > > say > > > > > > elm_button does with the label? > > > > > > > > > > > > > Dear all, > > > > > > > > > > > > > > This is a patch for elm_map for setting user-agent. > > > > > > > > > > > > > > - Add elm_map_user_agent_set > > > > > > > - Add elm_map_user_agent_get > > > > > > > - modify doxygen > > > > > > > > > > > > > > elm_map uses OSM(OpenStreetMap), but we can add custom map > > provider. > > > > > > > If custom map provider server filters robot out (currently > > default > > > > > > > user-agent is 'curl'), > > > > > > > we need some APIs to set/get user-agent. > > > > > > > > > > > > > > pls review this patch. > > > > > > > > > > > > > > Thanks. > > > > > > > BR > > > > > > > > > > > > > > > > > > -- > > > > > > ------------- Codito, ergo sum - "I code, therefore I am" > > > > -------------- > > > > > > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > ------------- Codito, ergo sum - "I code, therefore I am" > > -------------- > > > > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > > > > > > > > > > > > -- > > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
