Ok, I correct all these and I'll submit patches again. Thx for the feedback.
Le jeudi 10 mars 2011, Carsten Haitzler <ras...@rasterman.com> a écrit : > On Wed, 9 Mar 2011 16:24:10 +0100 Tristan Lelong > <tristan.lel...@blunderer.org> > said: > > ok. going to have to "reject" here. > > patch 1: > 1. formatting - elm_menu_discard() in Elementary.h.in doesnt align with the > rest of the calls next to it (looks ugly) > 2. elm_menu_discard() in elm_menu.c is indented using tabs, not spaces. make > it > align/look like all the code above/below it :) > > patch 2: > 3. elm_menu_item_selected_get() also not aligned in Elementary.h.in > 4. elm_menu_selected_item_get() also add a space between * and the function > call. > 5. more tabs in elm_menu.c indenting as opposed to spaces. > 6. ELM_CHECK_WIDTYPE() is changed to remove the NULL return - this creates a > bug. > 7. ELM_WIDGET_ITEM_WIDTYPE_CHECK_OR_RETURN provides no return value as arg in > elm_menu_item_selected_get(), elm_menu_item_prev_get(), elm_menu_item_next_get > () > 8. Eina_List * l there and not Eina_List *l. > 9. space between eina_list_data_find_list and () > 10. same with eina_list_next() and eina_list_prev() > > ... :) (don't worry - you'll learn that we are picky about these things) :) > >> Hello, >> >> I was using elementary on a target that only has a keyboard, and I add >> to do several modification on the elm_menu to handle keyboard >> navigation. >> - patch 1: discard a menu from C source code >> - patch 2: add accessors for menu items and add the ability to handle >> selected item from C source code >> >> >> >> -- >> 618FE3EF > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > -- 618FE3EF ------------------------------------------------------------------------------ Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
