+3 !
Using group data in theme looks better because it reduces source-gui
dependences.
group { name: "xx";
data.item: "count" "3";
You can fetch this data from c source using edje_object_data_get() API.
Please check other widgets for a reference.
I checked the patch very briefly and here are some comments.
1. Indentation.
ex) line 250 in elm_diskselector.diff
2. Blank lines.
There are 2 blank lines at the end of diff file. 396, 397 lines.
3. Diff file.
I think there is no rule for this but you can merge two diff files
to one diff file
because they are patches for a one feature and one library(elementary).
4. Sample code.
It will be better to have a sample code for a new feature in elementary_test.
Other than that, looks ok :)
Thanks.
Daniel Juyung Seo (SeoZ)
On Fri, Mar 18, 2011 at 5:57 AM, Tiago Falcao <develo...@tiagofalcao.com> wrote:
> +2 !
>
> When had see this widget in first time, I imagined it with option to
> many items but ever configured in theme.
> If i'm right, this widget is a lot dependent of code and less of theme :(
>
> What you thing about this, Shinwoo Kim?
> Gustavo suggested the easiest way, use group data.
>
> Thanks.
>
>
> On Thu, Mar 17, 2011 at 4:47 PM, Gustavo Sverzut Barbieri
> <barbi...@profusion.mobi> wrote:
>> On Thu, Mar 17, 2011 at 7:42 PM, Bruno Dilly <bdi...@profusion.mobi> wrote:
>>> On Thu, Mar 17, 2011 at 10:45 AM, cnook <kimci...@gmail.com> wrote:
>>>> Dear All,
>>>
>>> Hi Shinwoo Kim,
>>>
>>>>
>>>> This is Shinwoo Kim, learned that I could contribute to EFL! :)
>>>> I'm pleased to inform you that the patch for the "elm_diskselector".
>>>>
>>>> Until now, the "elm_diskselector" only display 3 items at once,
>>>> if you accept this patch, the "elm_diskselector" can display more than 3
>>>> items.
>>>
>>> Displaying more than 3 items is a nice improvement.
>>> What do you think about the idea of getting the number of items to be
>>> displayed from the theme ?
>>>
>>> Anyway, there is a typo on documentation (param num). Maybe a getter
>>> could be useful as well.
>>
>> +1 to get it from theme!
>>
>> I did something similar for ephoto in some older version, it had
>> couple of swallow parts defined, like "elm.swallow.p%d", and a
>> data.item: "count" "3", thus it would fill 3 swallows.
>>
>> I believe this is something up to the theme as it has the knowledge on
>> how to pack more items.
>>
>>
>> --
>> Gustavo Sverzut Barbieri
>> http://profusion.mobi embedded systems
>> --------------------------------------
>> MSN: barbi...@gmail.com
>> Skype: gsbarbieri
>> Mobile: +55 (19) 9225-2202
>>
>> ------------------------------------------------------------------------------
>> Colocation vs. Managed Hosting
>> A question and answer guide to determining the best fit
>> for your organization - today and in the future.
>> http://p.sf.net/sfu/internap-sfd2d
>> _______________________________________________
>> enlightenment-devel mailing list
>> enlightenment-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>>
>
>
>
> --
> Tiago Rezende Campos Falcão
> http://www.tiagofalcao.com
> --
> ProFUSION | embedded systems
> Computer Systems Laboratory - IC - Unicamp
> Grupo Pró Software Livre - Unicamp
> Laboratory of Information Systems - IC - Unicamp
>
> ------------------------------------------------------------------------------
> Colocation vs. Managed Hosting
> A question and answer guide to determining the best fit
> for your organization - today and in the future.
> http://p.sf.net/sfu/internap-sfd2d
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
