The right solution is to create a function inside efreet which handles path. Either fix what's currently there, or add some new function(s).
S. On 05/16/2011 10:46 PM, Mark-Willem Jansen wrote: > Me again, > > Just noticed that efreet has it own implementation of executing a program > based > on it desktop entry. One could use this efreet_desktop_exec() to execute > desktop > entries from e_exec(). It uses efreet_desktop_command_get() as e_exec() does, > but > has a different callback function to execute the program namely > efreet_desktop_exec_cb(). > > Unfortunately the callback in efreet seems a bit simple, when you compare it > to > the one used in e_exec.c. So I am not sure if the implementation is complete, > yet. > Also the doxygen info states that efreet_desktop_exec will return a Ecore_Exe > but > I fail to see that. As efreet_desktop_exec() does not return anything and also > efreet_desktop_exec_cb() will always return NULL and not the result of > ecore_exe_run(). > > Off course this can all be fixed. So one could use efreet_desktop_exec() > inside e_exec(). > Just let me know if this is reasonable and I will give it a shot. > > -- > Mark-Willem Jansen > ---------------------------------------- > From: [email protected] > To: [email protected] > Date: Mon, 16 May 2011 15:39:03 +0200 > Subject: Re: [E-devel] Path key in Desktop entry file not used > > > > Take two. > > tabs are expanded and the patch is now attached to the e-mail. > > -- > Mark-Willem Jansen > ---------------------------------------- >> From: [email protected] >> To: [email protected]; [email protected] >> Date: Mon, 16 May 2011 15:28:18 +0200 >> Subject: Re: [E-devel] Path key in Desktop entry file not used >> >> >> okay, >> >> made a small patch with some help from the IRC channel. >> >> Looks like the tabs are copied as spaces. >> >> -- >> Mark-Willem Jansen >> >> Index: src/bin/e_exec.c >> =================================================================== >> --- src/bin/e_exec.c (revision 56278) >> +++ src/bin/e_exec.c (working copy) >> @@ -210,7 +210,18 @@ >> // ECORE_EXE_PIPE_AUTO | ECORE_EXE_PIPE_READ | >> ECORE_EXE_PIPE_ERROR | >> // ECORE_EXE_PIPE_READ_LINE_BUFFERED | >> ECORE_EXE_PIPE_ERROR_LINE_BUFFERED, >> // inst); >> - exe = ecore_exe_run(exec, inst); >> + if (desktop->path) >> + { >> + if (!getcwd(buf, sizeof(buf))) return NULL; >> + if (chdir(desktop->path)) return NULL; >> + exe = ecore_exe_run(exec, inst); >> + if (chdir(buf)) return NULL; >> + } >> + else >> + { >> + exe = ecore_exe_run(exec, inst); >> + } >> + >> e_util_library_path_restore(); >> if (penv_display) >> { >> >> >> ---------------------------------------- >>> Date: Mon, 9 May 2011 22:00:01 +0200 >>> From: [email protected] >>> To: [email protected] >>> Subject: Re: [E-devel] Path key in Desktop entry file not used >>> >>> On 05/09/2011 12:39 PM, Mark-Willem Jansen wrote: >>>> Hi, >>>> >>>> Do I still need to file a bug on the tracker system, or is this entry in >>>> the mailing >>>> list enough. >>> It's enough here. >>> >>> S. >>> >>> ------------------------------------------------------------------------------ >>> WhatsUp Gold - Download Free Network Management Software >>> The most intuitive, comprehensive, and cost-effective network >>> management toolset available today. Delivers lowest initial >>> acquisition cost and overall TCO of any competing solution. >>> http://p.sf.net/sfu/whatsupgold-sd >>> _______________________________________________ >>> enlightenment-devel mailing list >>> [email protected] >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> >> ------------------------------------------------------------------------------ >> Achieve unprecedented app performance and reliability >> What every C/C++ and Fortran developer should know. >> Learn how Intel has extended the reach of its next-generation tools >> to help boost performance applications - inlcuding clusters. >> http://p.sf.net/sfu/intel-dev2devmay >> _______________________________________________ >> enlightenment-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > ------------------------------------------------------------------------------ > Achieve unprecedented app performance and reliability > What every C/C++ and Fortran developer should know. > Learn how Intel has extended the reach of its next-generation tools > to help boost performance applications - inlcuding clusters. > http://p.sf.net/sfu/intel-dev2devmay > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > ------------------------------------------------------------------------------ > Achieve unprecedented app performance and reliability > What every C/C++ and Fortran developer should know. > Learn how Intel has extended the reach of its next-generation tools > to help boost performance applications - inlcuding clusters. > http://p.sf.net/sfu/intel-dev2devmay > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ What Every C/C++ and Fortran developer Should Know! Read this article and learn how Intel has extended the reach of its next-generation tools to help Windows* and Linux* C/C++ and Fortran developers boost performance applications - including clusters. http://p.sf.net/sfu/intel-dev2devmay _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
