Hi, Raster.
I send again after fixing this patch according to your comment.
Would you please review again?
-----Original Message-----
From: Carsten Haitzler (The Rasterman) [mailto:ras...@rasterman.com]
Sent: Wednesday, July 06, 2011 6:23 PM
To: Jihoon Kim
Cc: enlightenment-devel@lists.sourceforge.net; 이지훈
Subject: Re: [E-devel] [PATCH] add ecore_imf_context_cursor_location_set API
On Tue, 05 Jul 2011 16:17:12 +0900 Jihoon Kim <jihoon48....@samsung.com>
said:
> Hi, EFL developers.
>
> In this patch, it will add ecore_imf_context_cursor_location_set API in
> Ecore_IMF.
>
> The cursor location can be used to determine the position of candidate
word
> window in immodule.
>
> Would you please apply this patch in svn?
reject! :) actually.. you broke ABI. you added cursor_location_set in the
middle of the struct.
--
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler) ras...@rasterman.com
Index: ChangeLog
===================================================================
--- ChangeLog (revision 61099)
+++ ChangeLog (working copy)
@@ -256,3 +256,7 @@
* Fix epoll delete fd handling in child process - #796
+2011-07-07 Jihoon Kim
+
+ * Ecore_IMF: Added ecore_imf_context_cursor_location_set API
+
Index: src/lib/ecore_imf/ecore_imf_context.c
===================================================================
--- src/lib/ecore_imf/ecore_imf_context.c (revision 61099)
+++ src/lib/ecore_imf/ecore_imf_context.c (working copy)
@@ -504,6 +504,29 @@ ecore_imf_context_cursor_position_set(Ecore_IMF_Co
}
/**
+ * Notify the Input Method Context that a change in the cursor
+ * location has been made. The location is relative to the canvas.
+ *
+ * @param ctx An #Ecore_IMF_Context.
+ * @param x cursor x position.
+ * @param x cursor y position.
+ * @param w cursor width.
+ * @param h cursor height.
+ * @ingroup Ecore_IMF_Context_Group
+ */
+EAPI void
+ecore_imf_context_cursor_location_set(Ecore_IMF_Context *ctx, int x, int y,
int w, int h)
+{
+ if (!ECORE_MAGIC_CHECK(ctx, ECORE_MAGIC_CONTEXT))
+ {
+ ECORE_MAGIC_FAIL(ctx, ECORE_MAGIC_CONTEXT,
+ "ecore_imf_context_cursor_position_set");
+ return;
+ }
+ if (ctx->klass->cursor_location_set) ctx->klass->cursor_location_set(ctx,
x, y, w, h);
+}
+
+/**
* Set whether the IM context should use the preedit string
* to display feedback. If @use_preedit is EINA_FALSE (default
* is EINA_TRUE), then the IM context may use some other method to display
Index: src/lib/ecore_imf/Ecore_IMF.h
===================================================================
--- src/lib/ecore_imf/Ecore_IMF.h (revision 61099)
+++ src/lib/ecore_imf/Ecore_IMF.h (working copy)
@@ -330,6 +330,7 @@ struct _Ecore_IMF_Context_Class
Ecore_IMF_Input_Panel_Layout (*input_panel_layout_get) (Ecore_IMF_Context
*ctx);
void (*input_panel_language_set) (Ecore_IMF_Context *ctx,
Ecore_IMF_Input_Panel_Lang lang);
Ecore_IMF_Input_Panel_Lang (*input_panel_language_get) (Ecore_IMF_Context
*ctx);
+ void (*cursor_location_set) (Ecore_IMF_Context *ctx, int x, int y, int w,
int h);
};
struct _Ecore_IMF_Context_Info
@@ -367,6 +368,7 @@ EAPI void ecore_imf_conte
EAPI void
ecore_imf_context_focus_out(Ecore_IMF_Context *ctx);
EAPI void ecore_imf_context_reset(Ecore_IMF_Context
*ctx);
EAPI void
ecore_imf_context_cursor_position_set(Ecore_IMF_Context *ctx, int cursor_pos);
+EAPI void
ecore_imf_context_cursor_location_set(Ecore_IMF_Context *ctx, int x, int y, int
w, int h);
EAPI void
ecore_imf_context_use_preedit_set(Ecore_IMF_Context *ctx, Eina_Bool
use_preedit);
EAPI void
ecore_imf_context_retrieve_surrounding_callback_set(Ecore_IMF_Context *ctx,
Eina_Bool (*func)(void *data, Ecore_IMF_Context *ctx, char **text, int
*cursor_pos), const void *data);
EAPI void
ecore_imf_context_input_mode_set(Ecore_IMF_Context *ctx, Ecore_IMF_Input_Mode
input_mode);
------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security
threats, fraudulent activity, and more. Splunk takes this data and makes
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
