In previous patch, version information (@since 1.1.0) is missed.
Would you please apply this patch in svn?
-----Original Message-----
From: Carsten Haitzler (The Rasterman) [mailto:ras...@rasterman.com]
Sent: Thursday, July 07, 2011 3:24 PM
To: Jihoon Kim
Cc: '이지훈'; enlightenment-devel@lists.sourceforge.net
Subject: Re: [E-devel] [PATCH] add ecore_imf_context_cursor_location_set API
On Thu, 07 Jul 2011 09:55:04 +0900 Jihoon Kim <jihoon48....@samsung.com> said:
yay! in svn! :) tnx!
> Hi, Raster.
>
> I send again after fixing this patch according to your comment.
> Would you please review again?
>
> -----Original Message-----
> From: Carsten Haitzler (The Rasterman) [mailto:ras...@rasterman.com]
> Sent: Wednesday, July 06, 2011 6:23 PM
> To: Jihoon Kim
> Cc: enlightenment-devel@lists.sourceforge.net; 이지훈
> Subject: Re: [E-devel] [PATCH] add ecore_imf_context_cursor_location_set API
>
> On Tue, 05 Jul 2011 16:17:12 +0900 Jihoon Kim <jihoon48....@samsung.com>
> said:
>
> > Hi, EFL developers.
> >
> > In this patch, it will add ecore_imf_context_cursor_location_set API in
> > Ecore_IMF.
> >
> > The cursor location can be used to determine the position of candidate
> word
> > window in immodule.
> >
> > Would you please apply this patch in svn?
>
> reject! :) actually.. you broke ABI. you added cursor_location_set in the
> middle of the struct.
>
>
> --
> ------------- Codito, ergo sum - "I code, therefore I am" --------------
> The Rasterman (Carsten Haitzler) ras...@rasterman.com
--
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler) ras...@rasterman.com
Index: ecore_imf_context.c
===================================================================
--- ecore_imf_context.c (revision 62170)
+++ ecore_imf_context.c (working copy)
@@ -513,6 +513,7 @@ ecore_imf_context_cursor_position_set(Ecore_IMF_Co
* @param w cursor width.
* @param h cursor height.
* @ingroup Ecore_IMF_Context_Group
+ * @since 1.1.0
*/
EAPI void
ecore_imf_context_cursor_location_set(Ecore_IMF_Context *ctx, int x, int y,
int w, int h)
------------------------------------------------------------------------------
BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA
The must-attend event for mobile developers. Connect with experts.
Get tools for creating Super Apps. See the latest technologies.
Sessions, hands-on labs, demos & much more. Register early & save!
http://p.sf.net/sfu/rim-blackberry-1
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
