Hi!

Your response always good for me.

1) Yes you're right,There would be a better solution than storing parent.
    I'll try to use other way that would use previous parent size if new
parent does not have enough size.


Sincerely,
Shinwoo Kim.


2011/7/25 Daniel Juyung Seo <seojuyu...@gmail.com>

> Hello Shinwoo Kim,
>
> 1) Why do you store parent? parent can be changed at any time.
>    ie) elm_box_pack_end()
>    I think it's better not to change the code.
>    Of course there are some exceptions but diskselector looks like a
> normal widget.
>
> 2) Setting it->label is ok.
>
> 3) When you make a diff, it's better add -x -up option.
>    $ svn diff -x -up
>    This tells you which function is changed in the diff.
>
> Thanks.
> Daniel Juyung Seo (SeoZ)
>
>
> On Mon, Jul 25, 2011 at 9:25 PM, cnook <kimci...@gmail.com> wrote:
> > Hi All,
> >
> > I have attached elm_diskselector patch for resolving dynamic theme change
> > issue.
> > Previously, the item label did not display when them theme had changed
> while
> > elm_diskselector displayed.
> >
> > Sincerely,
> > Shinwoo Kim.
> >
> >
> ------------------------------------------------------------------------------
> > Storage Efficiency Calculator
> > This modeling tool is based on patent-pending intellectual property that
> > has been used successfully in hundreds of IBM storage optimization
> engage-
> > ments, worldwide.  Store less, Store more with what you own, Move data to
> > the right place. Try It Now!
> http://www.accelacomm.com/jaw/sfnl/114/51427378/
> > _______________________________________________
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
> >
>
------------------------------------------------------------------------------
Magic Quadrant for Content-Aware Data Loss Prevention
Research study explores the data loss prevention market. Includes in-depth
analysis on the changes within the DLP market, and the criteria used to
evaluate the strengths and weaknesses of these DLP solutions.
http://www.accelacomm.com/jaw/sfnl/114/51385063/
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to