On Mon, 25 Jul 2011 21:25:36 +0900 cnook <kimci...@gmail.com> said: > Hi All, > > I have attached elm_diskselector patch for resolving dynamic theme change > issue. > Previously, the item label did not display when them theme had changed while > elm_diskselector displayed.
hmm this patch shows something disturbing... why is diskselector storing parent on creation? thats really bad. in fact... why get geometry og parent AS wd->minw? this makes no sense.... if disckselectro created initially as a child of win.. u'll be getting window geometry and setting that size to minw. thats wrong. if this were to actually use the current parent (which it does actually) then the parent width becomes the selectors min width.. this is wrong. imagine its in a horizontal box with 2 things horizontally.. this cant make logical sense. so i've removed the whole getting parent width for min width from the widget. it should be using the min_width data if set (i don't like this much.. but its not as bad as the parent thing).. the sizing_eval in the end calculates a min size which is right using the minw/h from theme data.. if it exists. -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Got Input? Slashdot Needs You. Take our quick survey online. Come on, we don't ask for help often. Plus, you'll get a chance to win $100 to spend on ThinkGeek. http://p.sf.net/sfu/slashdot-survey _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
