> Reading this ringed a BIG warning in my mind. You need to be careful > with the way Edje is done. I did not review the code, but let's > remember that:
> - All references are done by integer identifier. Order will affect > that! When you provide insert_before and insert_after, do you > recalculate all your ids and reassign them? I recall it was a painful > work to do in Edje_Edit The part id is assigned in the function "compile" and then the value of the part id is assigned to the variable which refer to it in the function "data_process_lookups". (compile -> data_process_lookups) I insert the function "reorder" between "compile" and "data_process_lookups". (compile -> reorder -> data_process_lookups) So the part id is refered after reordering. Because the part id is changed according the order of the part, we don't need to concern about that. > - remember about PART:"name" and PROGRAM:"name"... what to do when > part is deleted? Do you remember to create a new program and recompile > it with the new references on insert_before/after? > - what to do with dependencies? One part is relative to another... > it is deleted... then? If a part or program is deleted and any other part or program has the reference for it, edje_cc have to print ERROR and quit the compile. Currently edje_cc print ERROR and quit for non-exist reference. I think deleted part or program is same with that. It's error. > Please consider all these issues, create tests and prove it is right > before merging it. I smell lots of possible problems with this thing > :-/ I tested the reorder about many case. and it works well. If there is any error case, please let me know. Thanks. Jaehwan Kim. ------------------------------------------------------------------------------ BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA http://p.sf.net/sfu/rim-devcon-copy2 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
