On Mon, 5 Sep 2011 15:33:58 +0900 Naruto TAKAHASHI <tnar...@gmail.com> said:
actually it was the im_info thing i was asking about - never mind as that was a bit of the patch that was not needed. > this part moves get_ic(). > > filter_event() is occurred at input event(mount event or keyboard event). > when occurring mouse event, don't need to get XIC. > so I move get_ic() to in if(type == ECORE_IMF_EVENT_KEY_DOWN) nest. > > And the reason of deleting checking return value of get_ic() is > get_ic() has already checked same. > > I should have split this patch to particular. > > 2011/9/3 Carsten Haitzler <ras...@rasterman.com>: > > On Mon, 29 Aug 2011 18:18:31 +0900 Naruto TAKAHASHI <tnar...@gmail.com> > > said: > > > > hmm the 2nd part - if (!im_info) looks ok - but the first seems > > pointless/useless. why the first bit? > > > >> Hi All, > >> > >> I've added a checking null of im_info to get_ic(). > >> > >> Would you review this patch? > >> > >> Best Regards. > >> -- > >> Naruto TAKAHASHI > >> tnar...@gmail.com > > > > > > -- > > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > > > > > > -- > Naruto TAKAHASHI > tnar...@gmail.com > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2dcopy1 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
